Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix check marker style of Select selected item #15016

Merged
merged 2 commits into from Feb 23, 2019

Conversation

Projects
None yet
2 participants
@afc163
Copy link
Member

commented Feb 22, 2019

This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

What's the background?

Multiple select arrow is not align center.

default

Fix to:

default

Changelog description (Optional if not new feature)

  1. English description

🐛 Fixed that Select check icon is not aligned center. #15016

  1. Chinese description (optional)

🐛 修复 Select 选中图标位置偏下的问题。#15016

Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Additional Plan? (Optional if not new feature)

If this PR related with other PR or following info. You can type here.

@ztplz

ztplz approved these changes Feb 22, 2019

@netlify

This comment has been minimized.

Copy link

commented Feb 22, 2019

Deploy preview for ant-design ready!

Built with commit e4eb596

https://deploy-preview-15016--ant-design.netlify.com

@afc163 afc163 force-pushed the fix-select-arrow-position branch from 8831326 to 2df2dc0 Feb 22, 2019

@codecov

This comment has been minimized.

Copy link

commented Feb 22, 2019

Codecov Report

Merging #15016 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15016      +/-   ##
==========================================
- Coverage   92.78%   92.75%   -0.04%     
==========================================
  Files         236      236              
  Lines        6239     6239              
  Branches     1865     1854      -11     
==========================================
- Hits         5789     5787       -2     
  Misses        449      449              
- Partials        1        3       +2
Impacted Files Coverage Δ
components/upload/UploadList.tsx 87.15% <0%> (-1.84%) ⬇️
components/transfer/index.tsx 85.43% <0%> (ø) ⬆️
components/time-picker/index.tsx 82.85% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d46fa9...e4eb596. Read the comment docs.

@afc163 afc163 merged commit efafa63 into master Feb 23, 2019

27 of 29 checks passed

Header rules No header rules processed
Details
Pages changed 13 new files uploaded
Details
AccessLint Review complete
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
CodeFactor No issues found.
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
License Compliance All checks passed.
Details
Mixed content No mixed content detected
Details
Redirect rules 18 redirect rules processed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 5d46fa9...e4eb596
Details
codecov/project 92.75% (-0.04%) compared to 5d46fa9
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@delete-merged-branch delete-merged-branch bot deleted the fix-select-arrow-position branch Feb 23, 2019

@afc163 afc163 referenced this pull request Feb 23, 2019

Merged

✨ 3.13.6 #15018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.