Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Table filter can not support other type of value #15046

Merged
merged 5 commits into from Feb 26, 2019

Conversation

Projects
None yet
3 participants
@zombieJ
Copy link
Member

zombieJ commented Feb 26, 2019

First of all, thank you for your contribution! 😄

New feature please send pull request to feature branch, and rest to master branch.
Pull request will be merged after one of collaborators approve.
Please makes sure that these form are filled before submitting your pull request, thank you!

[中文版模板 / Chinese template]

This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

What's the background?

fix #9916

What's the effect? (Optional if not new feature)

Support other types in filter

Changelog description (Optional if not new feature)

  • Fix Table filter can not support other type of value.
  • 修复 Table 筛选不支持 string 以外类型的问题。

Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

zombieJ added some commits Feb 25, 2019

@zombieJ zombieJ requested review from afc163 and ztplz Feb 26, 2019

@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 26, 2019

Codecov Report

Merging #15046 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15046      +/-   ##
==========================================
+ Coverage   92.79%    92.8%   +0.01%     
==========================================
  Files         236      236              
  Lines        6242     6256      +14     
  Branches     1869     1873       +4     
==========================================
+ Hits         5792     5806      +14     
  Misses        447      447              
  Partials        3        3
Impacted Files Coverage Δ
components/table/filterDropdown.tsx 94.87% <100%> (+0.42%) ⬆️
components/table/util.tsx 97.77% <100%> (+0.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb6a493...e20d250. Read the comment docs.

@netlify

This comment has been minimized.

Copy link

netlify bot commented Feb 26, 2019

Deploy preview for ant-design ready!

Built with commit e20d250

https://deploy-preview-15046--ant-design.netlify.com

@afc163

This comment has been minimized.

@ztplz

ztplz approved these changes Feb 26, 2019

@afc163

afc163 approved these changes Feb 26, 2019

@zombieJ zombieJ merged commit a802a72 into master Feb 26, 2019

24 checks passed

AccessLint Review complete
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
CodeFactor 1 issue fixed.
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
License Compliance All checks passed.
Details
ant-design.ant-design #ant design succeeded
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 92.79%)
Details
codecov/project 92.8% (+0.01%) compared to fb6a493
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@delete-merged-branch delete-merged-branch bot deleted the table-filter-value branch Feb 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.