Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Table filter can not support other type of value #15046

Merged
merged 5 commits into from Feb 26, 2019
Merged

Conversation

@zombieJ
Copy link
Member

@zombieJ zombieJ commented Feb 26, 2019

First of all, thank you for your contribution! 😄

New feature please send pull request to feature branch, and rest to master branch.
Pull request will be merged after one of collaborators approve.
Please makes sure that these form are filled before submitting your pull request, thank you!

[中文版模板 / Chinese template]

This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

What's the background?

fix #9916

What's the effect? (Optional if not new feature)

Support other types in filter

Changelog description (Optional if not new feature)

  • Fix Table filter can not support other type of value.
  • 修复 Table 筛选不支持 string 以外类型的问题。

Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed
@zombieJ zombieJ requested review from afc163 and ztplz Feb 26, 2019
@codecov
Copy link

@codecov codecov bot commented Feb 26, 2019

Codecov Report

Merging #15046 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15046      +/-   ##
==========================================
+ Coverage   92.79%    92.8%   +0.01%     
==========================================
  Files         236      236              
  Lines        6242     6256      +14     
  Branches     1869     1873       +4     
==========================================
+ Hits         5792     5806      +14     
  Misses        447      447              
  Partials        3        3
Impacted Files Coverage Δ
components/table/filterDropdown.tsx 94.87% <100%> (+0.42%) ⬆️
components/table/util.tsx 97.77% <100%> (+0.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb6a493...e20d250. Read the comment docs.

@netlify
Copy link

@netlify netlify bot commented Feb 26, 2019

Deploy preview for ant-design ready!

Built with commit e20d250

https://deploy-preview-15046--ant-design.netlify.com

ztplz
ztplz approved these changes Feb 26, 2019
afc163
afc163 approved these changes Feb 26, 2019
@zombieJ zombieJ merged commit a802a72 into master Feb 26, 2019
30 checks passed
@delete-merged-branch delete-merged-branch bot deleted the table-filter-value branch Feb 26, 2019
@webel
Copy link

@webel webel commented Sep 25, 2020

I am having this problem with antd@4.3.0, I've checked the docs but cannot find any info regarding the necessity to add a property, or similar, on the filterable column. I've confirmed that handleTableChange receives filters stringified, regardless of underlying type (int, bool).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants