Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cascader should tab twice to exist #15117

Merged
merged 2 commits into from Mar 1, 2019
Merged

fix cascader should tab twice to exist #15117

merged 2 commits into from Mar 1, 2019

Conversation

@zombieJ
Copy link
Member

@zombieJ zombieJ commented Mar 1, 2019

First of all, thank you for your contribution! 😄

New feature please send pull request to feature branch, and rest to master branch.
Pull request will be merged after one of collaborators approve.
Please makes sure that these form are filled before submitting your pull request, thank you!

[中文版模板 / Chinese template]

This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

What's the background?

fix #15115

Changelog description (Optional if not new feature)

  1. Fix Cascader should tab twice to exist.
  2. 修复 Cascader 需要按 Tab 两次切换聚焦的问题。

Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed
@netlify
Copy link

@netlify netlify bot commented Mar 1, 2019

Deploy preview for ant-design ready!

Built with commit 71afd9b

https://deploy-preview-15117--ant-design.netlify.com

@codecov
Copy link

@codecov codecov bot commented Mar 1, 2019

Codecov Report

Merging #15117 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15117      +/-   ##
==========================================
+ Coverage   92.77%   92.81%   +0.03%     
==========================================
  Files         236      236              
  Lines        6260     6260              
  Branches     1841     1841              
==========================================
+ Hits         5808     5810       +2     
+ Misses        451      449       -2     
  Partials        1        1
Impacted Files Coverage Δ
components/cascader/index.tsx 96.85% <ø> (ø) ⬆️
components/upload/UploadList.tsx 88.99% <0%> (+1.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34eafbf...442b1c7. Read the comment docs.

@netlify
Copy link

@netlify netlify bot commented Mar 1, 2019

Deploy preview for ant-design ready!

Built with commit 442b1c7

https://deploy-preview-15117--ant-design.netlify.com

@zombieJ zombieJ merged commit 66786c7 into master Mar 1, 2019
31 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix-cascader-multi-tab branch Mar 1, 2019
chenshuai2144 added a commit that referenced this issue Mar 4, 2019
* add responsive property to carousel (#15071)

* add responsive property to carousel #15065

* extend carousel props from Slick type definitions #15065

* rm key in OptionProps (#15104)

* update doc

* fix cascader should tab twice to exist (#15117)

* fix cascader should tab twice to exist

* update snapshot

* Drawer Body padding should be variable

* fix DatePicker to support an array of formats (#15116)

ref #13148

* table reader mobile friendly

* up

* up

* doc: add 3.14.0 changelog

* doc: fix ci warning

* doc: fix ci warning

* doc: fix typo

* doc: fix ci warning

* doc: fix ci warning

* doc: fix cr warring

* doc: fix cr warring

* doc: fix cr warring

* doc: fix cr warring

* doc: fix cr warring

* doc: fix cr warring

* doc: fix cr warring

* -m

* -m

* doc: fix cr warning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

1 participant