Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cascader should tab twice to exist #15117

Merged
merged 2 commits into from Mar 1, 2019

Conversation

Projects
None yet
1 participant
@zombieJ
Copy link
Member

commented Mar 1, 2019

First of all, thank you for your contribution! 😄

New feature please send pull request to feature branch, and rest to master branch.
Pull request will be merged after one of collaborators approve.
Please makes sure that these form are filled before submitting your pull request, thank you!

[中文版模板 / Chinese template]

This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

What's the background?

fix #15115

Changelog description (Optional if not new feature)

  1. Fix Cascader should tab twice to exist.
  2. 修复 Cascader 需要按 Tab 两次切换聚焦的问题。

Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

zombieJ added some commits Mar 1, 2019

@netlify

This comment has been minimized.

Copy link

commented Mar 1, 2019

Deploy preview for ant-design ready!

Built with commit 71afd9b

https://deploy-preview-15117--ant-design.netlify.com

@codecov

This comment has been minimized.

Copy link

commented Mar 1, 2019

Codecov Report

Merging #15117 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15117      +/-   ##
==========================================
+ Coverage   92.77%   92.81%   +0.03%     
==========================================
  Files         236      236              
  Lines        6260     6260              
  Branches     1841     1841              
==========================================
+ Hits         5808     5810       +2     
+ Misses        451      449       -2     
  Partials        1        1
Impacted Files Coverage Δ
components/cascader/index.tsx 96.85% <ø> (ø) ⬆️
components/upload/UploadList.tsx 88.99% <0%> (+1.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34eafbf...442b1c7. Read the comment docs.

@netlify

This comment has been minimized.

Copy link

commented Mar 1, 2019

Deploy preview for ant-design ready!

Built with commit 442b1c7

https://deploy-preview-15117--ant-design.netlify.com

@zombieJ zombieJ merged commit 66786c7 into master Mar 1, 2019

29 of 31 checks passed

Header rules No header rules processed
Details
Pages changed 13 new files uploaded
Details
AccessLint Review complete
Auto Assign Auto Assign
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
CodeFactor No issues found.
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
License Compliance All checks passed.
Details
Mixed content No mixed content detected
Details
Redirect rules 18 redirect rules processed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codebeat no reportable quality changes
Details
codecov/patch Coverage not affected when comparing 34eafbf...442b1c7
Details
codecov/project 92.81% (+0.03%) compared to 34eafbf
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@delete-merged-branch delete-merged-branch bot deleted the fix-cascader-multi-tab branch Mar 1, 2019

chenshuai2144 added a commit that referenced this pull request Mar 4, 2019

3.14.0 Changelog (#15145)
* add responsive property to carousel (#15071)

* add responsive property to carousel #15065

* extend carousel props from Slick type definitions #15065

* rm key in OptionProps (#15104)

* update doc

* fix cascader should tab twice to exist (#15117)

* fix cascader should tab twice to exist

* update snapshot

* Drawer Body padding should be variable

* fix DatePicker to support an array of formats (#15116)

ref #13148

* table reader mobile friendly

* up

* up

* doc: add 3.14.0 changelog

* doc: fix ci warning

* doc: fix ci warning

* doc: fix typo

* doc: fix ci warning

* doc: fix ci warning

* doc: fix cr warring

* doc: fix cr warring

* doc: fix cr warring

* doc: fix cr warring

* doc: fix cr warring

* doc: fix cr warring

* doc: fix cr warring

* -m

* -m

* doc: fix cr warning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.