Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix cascader should tab twice to exist #15117

Merged
merged 2 commits into from Mar 1, 2019
Merged

fix cascader should tab twice to exist #15117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
71afd9b
fix cascader should tab twice to exist
zombieJ Mar 1, 2019
442b1c7
update snapshot
zombieJ Mar 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 14 additions & 0 deletions components/cascader/__tests__/__snapshots__/demo.test.js.snap
View file
Open in desktop
Expand Up @@ -13,6 +13,7 @@ exports[`renders ./components/cascader/demo/basic.md correctly 1`] = `
class="ant-input ant-cascader-input "
placeholder="Please select"
readonly=""
tabindex="-1"
type="text"
value=""
/>
Expand Down Expand Up @@ -50,6 +51,7 @@ exports[`renders ./components/cascader/demo/change-on-select.md correctly 1`] =
class="ant-input ant-cascader-input "
placeholder="Please select"
readonly=""
tabindex="-1"
type="text"
value=""
/>
Expand Down Expand Up @@ -101,6 +103,7 @@ exports[`renders ./components/cascader/demo/custom-render.md correctly 1`] = `
autocomplete="off"
class="ant-input ant-cascader-input "
readonly=""
tabindex="-1"
type="text"
value=""
/>
Expand Down Expand Up @@ -170,6 +173,7 @@ exports[`renders ./components/cascader/demo/default-value.md correctly 1`] = `
autocomplete="off"
class="ant-input ant-cascader-input "
readonly=""
tabindex="-1"
type="text"
value=""
/>
Expand Down Expand Up @@ -226,6 +230,7 @@ exports[`renders ./components/cascader/demo/disabled-option.md correctly 1`] = `
class="ant-input ant-cascader-input "
placeholder="Please select"
readonly=""
tabindex="-1"
type="text"
value=""
/>
Expand Down Expand Up @@ -263,6 +268,7 @@ exports[`renders ./components/cascader/demo/fields-name.md correctly 1`] = `
class="ant-input ant-cascader-input "
placeholder="Please select"
readonly=""
tabindex="-1"
type="text"
value=""
/>
Expand Down Expand Up @@ -300,6 +306,7 @@ exports[`renders ./components/cascader/demo/hover.md correctly 1`] = `
class="ant-input ant-cascader-input "
placeholder="Please select"
readonly=""
tabindex="-1"
type="text"
value=""
/>
Expand Down Expand Up @@ -337,6 +344,7 @@ exports[`renders ./components/cascader/demo/lazy.md correctly 1`] = `
class="ant-input ant-cascader-input "
placeholder="Please select"
readonly=""
tabindex="-1"
type="text"
value=""
/>
Expand Down Expand Up @@ -373,6 +381,7 @@ exports[`renders ./components/cascader/demo/search.md correctly 1`] = `
autocomplete="off"
class="ant-input ant-cascader-input "
placeholder="Please select"
tabindex="-1"
type="text"
value=""
/>
Expand Down Expand Up @@ -411,6 +420,7 @@ exports[`renders ./components/cascader/demo/size.md correctly 1`] = `
class="ant-input ant-cascader-input ant-input-lg"
placeholder="Please select"
readonly=""
tabindex="-1"
type="text"
value=""
/>
Expand Down Expand Up @@ -447,6 +457,7 @@ exports[`renders ./components/cascader/demo/size.md correctly 1`] = `
class="ant-input ant-cascader-input "
placeholder="Please select"
readonly=""
tabindex="-1"
type="text"
value=""
/>
Expand Down Expand Up @@ -483,6 +494,7 @@ exports[`renders ./components/cascader/demo/size.md correctly 1`] = `
class="ant-input ant-cascader-input ant-input-sm"
placeholder="Please select"
readonly=""
tabindex="-1"
type="text"
value=""
/>
Expand Down Expand Up @@ -524,6 +536,7 @@ exports[`renders ./components/cascader/demo/suffix.md correctly 1`] = `
class="ant-input ant-cascader-input "
placeholder="Please select"
readonly=""
tabindex="-1"
type="text"
value=""
/>
Expand Down Expand Up @@ -559,6 +572,7 @@ exports[`renders ./components/cascader/demo/suffix.md correctly 1`] = `
class="ant-input ant-cascader-input "
placeholder="Please select"
readonly=""
tabindex="-1"
type="text"
value=""
/>
Expand Down
1 change: 1 addition & 0 deletions components/cascader/__tests__/__snapshots__/index.test.js.snap
View file
Open in desktop
Expand Up @@ -1237,6 +1237,7 @@ exports[`Cascader support controlled mode 1`] = `
autocomplete="off"
class="ant-input ant-cascader-input "
readonly=""
tabindex="-1"
type="text"
value=""
/>
Expand Down
1 change: 1 addition & 0 deletions components/cascader/index.tsx
View file
Open in desktop
Expand Up @@ -520,6 +520,7 @@ class Cascader extends React.Component<CascaderProps, CascaderState> {
<span className={`${prefixCls}-picker-label`}>{this.getLabel()}</span>
<Input
{...inputProps}
tabIndex="-1"
ref={this.saveInput}
prefixCls={inputPrefixCls}
placeholder={value && value.length > 0 ? undefined : placeholder}
Expand Down
3 changes: 3 additions & 0 deletions components/config-provider/__tests__/__snapshots__/components.test.js.snap
View file
Open in desktop
Expand Up @@ -5799,6 +5799,7 @@ exports[`ConfigProvider components Cascader configProvider 1`] = `
autocomplete="off"
class="config-input config-cascader-input "
placeholder="Please select"
tabindex="-1"
type="text"
value=""
/>
Expand Down Expand Up @@ -5835,6 +5836,7 @@ exports[`ConfigProvider components Cascader normal 1`] = `
autocomplete="off"
class="ant-input ant-cascader-input "
placeholder="Please select"
tabindex="-1"
type="text"
value=""
/>
Expand Down Expand Up @@ -5871,6 +5873,7 @@ exports[`ConfigProvider components Cascader prefixCls 1`] = `
autocomplete="off"
class="ant-input prefix-Cascader-input "
placeholder="Please select"
tabindex="-1"
type="text"
value=""
/>
Expand Down
1 change: 1 addition & 0 deletions components/empty/__tests__/__snapshots__/demo.test.js.snap
View file
Open in desktop
Expand Up @@ -146,6 +146,7 @@ exports[`renders ./components/empty/demo/config-provider.md correctly 1`] = `
autocomplete="off"
class="ant-input ant-cascader-input "
placeholder="Please select"
tabindex="-1"
type="text"
value=""
/>
Expand Down
2 changes: 2 additions & 0 deletions components/form/__tests__/__snapshots__/demo.test.js.snap
View file
Open in desktop
Expand Up @@ -1711,6 +1711,7 @@ exports[`renders ./components/form/demo/register.md correctly 1`] = `
data-__meta="[object Object]"
id="register_residence"
readonly=""
tabindex="-1"
type="text"
value=""
/>
Expand Down Expand Up @@ -4692,6 +4693,7 @@ exports[`renders ./components/form/demo/validate-static.md correctly 1`] = `
autocomplete="off"
class="ant-input ant-cascader-input "
readonly=""
tabindex="-1"
type="text"
value=""
/>
Expand Down
1 change: 1 addition & 0 deletions components/input/__tests__/__snapshots__/demo.test.js.snap
View file
Open in desktop
Expand Up @@ -898,6 +898,7 @@ exports[`renders ./components/input/demo/group.md correctly 1`] = `
class="ant-input ant-cascader-input "
placeholder="Select Address"
readonly=""
tabindex="-1"
type="text"
value=""
/>
Expand Down