Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drawer Body padding should be variable #15120

Merged
merged 1 commit into from
Mar 1, 2019

Conversation

yoyo837
Copy link
Contributor

@yoyo837 yoyo837 commented Mar 1, 2019

First of all, thank you for your contribution! 😄

New feature please send pull request to feature branch, and rest to master branch.
Pull request will be merged after one of collaborators approve.
Please makes sure that these form are filled before submitting your pull request, thank you!

[中文版模板 / Chinese template]

This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

What's the background?

  1. Describe the source of requirement.
  2. Resolve what problem.
  3. Related issue link.

fix #14862

API Realization (Optional if not new feature)

  1. Basic thought of solution and other optional proposal.
  2. List final API realization and usage sample.
  3. GIF or snapshot should be provided if includes UI/interactive modification.

What's the effect? (Optional if not new feature)

  1. Does this PR affect user? Which part will be affected?
  2. What will say in changelog?
  3. Does this PR contains potential break change or other risk?

Changelog description (Optional if not new feature)

  1. English description
  2. Chinese description (optional)

Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Additional Plan? (Optional if not new feature)

If this PR related with other PR or following info. You can type here.

@afc163 afc163 merged commit 29647f0 into ant-design:master Mar 1, 2019
@yoyo837 yoyo837 deleted the drawer-variable branch March 1, 2019 03:24
@netlify
Copy link

netlify bot commented Mar 1, 2019

Deploy preview for ant-design ready!

Built with commit b1a3850

https://deploy-preview-15120--ant-design.netlify.com

@codecov
Copy link

codecov bot commented Mar 1, 2019

Codecov Report

Merging #15120 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15120      +/-   ##
==========================================
+ Coverage   92.77%   92.81%   +0.03%     
==========================================
  Files         236      236              
  Lines        6260     6260              
  Branches     1841     1873      +32     
==========================================
+ Hits         5808     5810       +2     
+ Misses        451      449       -2     
  Partials        1        1
Impacted Files Coverage Δ
components/upload/UploadList.tsx 88.99% <0%> (+1.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34eafbf...b1a3850. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drawer Body padding is fixed value - should be variable
2 participants