Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust slider text style #15128

Merged
merged 3 commits into from Apr 28, 2019

Conversation

Projects
None yet
3 participants
@zombieJ
Copy link
Member

commented Mar 1, 2019

First of all, thank you for your contribution! 😄

New feature please send pull request to feature branch, and rest to master branch.
Pull request will be merged after one of collaborators approve.
Please makes sure that these form are filled before submitting your pull request, thank you!

[中文版模板 / Chinese template]

This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

What's the background?

fix #15127

Changelog description (Optional if not new feature)

  1. Fix Slider mark text style will break line.
  2. 修复 Slider 的文字会换行的问题。

Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@zombieJ zombieJ requested review from afc163 and ztplz Mar 1, 2019

@afc163

This comment has been minimized.

Copy link
Member

commented Mar 1, 2019

万一就是要换行呢

@codecov

This comment has been minimized.

Copy link

commented Mar 1, 2019

Codecov Report

Merging #15128 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #15128   +/-   ##
=======================================
  Coverage   92.78%   92.78%           
=======================================
  Files         237      237           
  Lines        6261     6261           
  Branches     1838     1838           
=======================================
  Hits         5809     5809           
  Misses        451      451           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e26c513...dae5467. Read the comment docs.

@netlify

This comment has been minimized.

Copy link

commented Mar 1, 2019

Deploy preview for ant-design failed.

Built with commit 73aaf0a

https://app.netlify.com/sites/ant-design/deploys/5cc554968642b60008f8dd29

@codecov

This comment has been minimized.

Copy link

commented Mar 1, 2019

Codecov Report

Merging #15128 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15128      +/-   ##
==========================================
+ Coverage   95.28%   95.32%   +0.04%     
==========================================
  Files         253      253              
  Lines        6780     6780              
  Branches     1970     1933      -37     
==========================================
+ Hits         6460     6463       +3     
+ Misses        319      316       -3     
  Partials        1        1
Impacted Files Coverage Δ
components/_util/wave.tsx 88.46% <0%> (+2.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61f7003...73aaf0a. Read the comment docs.

@zombieJ

This comment has been minimized.

Copy link
Member Author

commented Mar 1, 2019

万一就是要换行呢

那直接 revert 掉这个如何? react-component/slider@060d8c6#diff-7c429cf3d38f312b214ce1b8b3828528

@pr-triage pr-triage bot added the PR: unreviewed label Apr 28, 2019

@zombieJ zombieJ merged commit 5469bba into master Apr 28, 2019

24 of 30 checks passed

Header rules Deploy failed
Details
Mixed content Deploy failed
Details
Pages changed Deploy failed
Details
Redirect rules Deploy failed
Details
deploy/netlify Deploy preview failed.
Details
Semantic Pull Request add a semantic commit or PR title
Details
CodeFactor No issues found.
Details
LGTM analysis: JavaScript No code changes detected
Details
License Compliance All checks passed.
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize No change
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codebeat 6 issues resolved and 6 introduced
Details
codecov/patch Coverage not affected when comparing 61f7003...73aaf0a
Details
codecov/project 95.32% (+0.04%) compared to 61f7003
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@pr-triage pr-triage bot added the PR: merged label Apr 28, 2019

@delete-merged-branch delete-merged-branch bot deleted the slider-mark branch Apr 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.