Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix configProvider getPopupContainer not work with DatePicker #15156

Merged
merged 1 commit into from Mar 4, 2019

Conversation

Projects
None yet
2 participants
@zombieJ
Copy link
Member

commented Mar 4, 2019

First of all, thank you for your contribution! 😄

New feature please send pull request to feature branch, and rest to master branch.
Pull request will be merged after one of collaborators approve.
Please makes sure that these form are filled before submitting your pull request, thank you!

[中文版模板 / Chinese template]

This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

What's the background?

close #13395

API Realization (Optional if not new feature)

<ConfigProvider
          getPopupContainer={ele => ele.parentNode}
        >
          <DatePicker  />
</ConfigProvider>

Changelog description (Optional if not new feature)

  1. fix getPopupContainer of ConfigProvider not work with DatePicker.
  2. 修复 ConfigProvider 中 getPopupContainer 对于 DatePicker 无效的问题。

Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@zombieJ zombieJ requested review from afc163 and ztplz Mar 4, 2019

@netlify

This comment has been minimized.

Copy link

commented Mar 4, 2019

Deploy preview for ant-design ready!

Built with commit 0af6bde

https://deploy-preview-15156--ant-design.netlify.com

@codecov

This comment has been minimized.

Copy link

commented Mar 4, 2019

Codecov Report

Merging #15156 into master will decrease coverage by 0.21%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15156      +/-   ##
==========================================
- Coverage   93.32%   93.11%   -0.22%     
==========================================
  Files         249      237      -12     
  Lines        6671     6262     -409     
  Branches     1925     1871      -54     
==========================================
- Hits         6226     5831     -395     
+ Misses        444      430      -14     
  Partials        1        1
Impacted Files Coverage Δ
components/date-picker/wrapPicker.tsx 100% <100%> (ø) ⬆️
components/input/TextArea.tsx 88.05% <0%> (-6.49%) ⬇️
components/statistic/Countdown.tsx 96.29% <0%> (-3.71%) ⬇️
components/config-provider/index.tsx 93.1% <0%> (-1.02%) ⬇️
components/form/FormItem.tsx 96.42% <0%> (-0.09%) ⬇️
components/collapse/CollapsePanel.tsx 100% <0%> (ø) ⬆️
components/layout/layout.tsx 90.62% <0%> (ø) ⬆️
components/icon/index.tsx 88% <0%> (ø) ⬆️
components/_util/type.ts 100% <0%> (ø) ⬆️
components/_util/raf.ts 100% <0%> (ø) ⬆️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2996d8e...0af6bde. Read the comment docs.

@afc163 afc163 merged commit 19d916f into master Mar 4, 2019

28 of 31 checks passed

codebeat 0 issues resolved and 1 introduced
Details
Header rules No header rules processed
Details
Pages changed 12 new files uploaded
Details
AccessLint Review complete
Auto Assign Auto Assign
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
CodeFactor No issues found.
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
License Compliance All checks passed.
Details
Mixed content No mixed content detected
Details
Redirect rules 18 redirect rules processed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 93.32%)
Details
codecov/project Absolute coverage decreased by -0.21% but relative coverage increased by +6.67% compared to 2996d8e
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No new issues
Details

@delete-merged-branch delete-merged-branch bot deleted the date-picker-popup branch Mar 4, 2019

@afc163 afc163 referenced this pull request Mar 4, 2019

Merged

Add 3.14.1 changelog #15175

3 of 13 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.