Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: PageHeader support classname #15159

merged 1 commit into from Mar 4, 2019

feat: PageHeader support classname #15159

merged 1 commit into from Mar 4, 2019


Copy link

@chenshuai2144 chenshuai2144 commented Mar 4, 2019

First of all, thank you for your contribution! 😄

New feature please send pull request to feature branch, and rest to master branch.
Pull request will be merged after one of collaborators approve.
Please makes sure that these form are filled before submitting your pull request, thank you!

[中文版模板 / Chinese template]

This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

What's the background?


API Realization (Optional if not new feature)

  1. Basic thought of solution and other optional proposal.
  2. List final API realization and usage sample.
  3. GIF or snapshot should be provided if includes UI/interactive modification.

What's the effect? (Optional if not new feature)

  1. Does this PR affect user? Which part will be affected?
  2. What will say in changelog?
  3. Does this PR contains potential break change or other risk?

Changelog description (Optional if not new feature)

 1. English description
    PageHeader support `classname` prop.
 2. Chinese description (optional)
    PageHeader 支持 `className` prop。

Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Additional Plan? (Optional if not new feature)

If this PR related with other PR or following info. You can type here.

Copy link

@codecov codecov bot commented Mar 4, 2019

Codecov Report

Merging #15159 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #15159   +/-   ##
  Coverage   93.32%   93.32%           
  Files         249      249           
  Lines        6671     6671           
  Branches     1925     1945   +20     
  Hits         6226     6226           
+ Misses        444      442    -2     
- Partials        1        3    +2
Impacted Files Coverage Δ
components/page-header/index.tsx 100% <100%> (ø) ⬆️
components/time-picker/index.tsx 81.94% <0%> (ø) ⬆️
components/transfer/index.tsx 85.43% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2996d8e...2205380. Read the comment docs.

Copy link

@netlify netlify bot commented Mar 4, 2019

Deploy preview for ant-design ready!

Built with commit 2205380

zombieJ approved these changes Mar 4, 2019
@zombieJ zombieJ merged commit f73a0e2 into master Mar 4, 2019
30 of 31 checks passed
@zombieJ zombieJ deleted the pageHeader-classname branch Mar 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants