Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix form warning #15160

Merged
merged 2 commits into from Mar 4, 2019

Conversation

Projects
None yet
3 participants
@zombieJ
Copy link
Member

commented Mar 4, 2019

First of all, thank you for your contribution! 😄

New feature please send pull request to feature branch, and rest to master branch.
Pull request will be merged after one of collaborators approve.
Please makes sure that these form are filled before submitting your pull request, thank you!

[中文版模板 / Chinese template]

This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

What's the background?

2019-03-04 2 18 01

Changelog description (Optional if not new feature)

  1. Fix Form warning with unique key & additional attributes.
  2. 修复 Form 警告信息。

Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@zombieJ zombieJ requested review from afc163 and ztplz Mar 4, 2019

@netlify

This comment has been minimized.

Copy link

commented Mar 4, 2019

Deploy preview for ant-design ready!

Built with commit 5baaaa4

https://deploy-preview-15160--ant-design.netlify.com

@codecov

This comment has been minimized.

Copy link

commented Mar 4, 2019

Codecov Report

Merging #15160 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15160      +/-   ##
==========================================
+ Coverage   93.32%   93.37%   +0.04%     
==========================================
  Files         249      249              
  Lines        6671     6671              
  Branches     1925     1957      +32     
==========================================
+ Hits         6226     6229       +3     
+ Misses        444      439       -5     
- Partials        1        3       +2
Impacted Files Coverage Δ
components/form/Form.tsx 88.88% <ø> (ø) ⬆️
components/form/FormItem.tsx 96.51% <100%> (ø) ⬆️
components/time-picker/index.tsx 81.94% <0%> (ø) ⬆️
components/transfer/index.tsx 85.43% <0%> (ø) ⬆️
components/_util/wave.tsx 87.5% <0%> (+2.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2996d8e...5baaaa4. Read the comment docs.

@zombieJ zombieJ merged commit 2f6b367 into master Mar 4, 2019

29 of 31 checks passed

Header rules No header rules processed
Details
Pages changed 12 new files uploaded
Details
AccessLint Review complete
Auto Assign Auto Assign
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
CodeFactor No issues found.
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
License Compliance All checks passed.
Details
Mixed content No mixed content detected
Details
Redirect rules 18 redirect rules processed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codebeat no reportable quality changes
Details
codecov/patch 100% of diff hit (target 93.32%)
Details
codecov/project 93.37% (+0.04%) compared to 2996d8e
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@delete-merged-branch delete-merged-branch bot deleted the form-item-keys branch Mar 4, 2019

@afc163 afc163 referenced this pull request Mar 4, 2019

Closed

FormItem Context.Consumer key warning #15166

0 of 1 task complete
@fifsky

This comment has been minimized.

Copy link

commented Mar 5, 2019

me too, but my version 1.14.1 the bug still exists

@zombieJ

This comment has been minimized.

Copy link
Member Author

commented Mar 5, 2019

me too, but my version 1.14.1 the bug still exists

Hi, could you try remove node_modules and reinstall? If warning still exists, pls help to create a issue for this.

@fifsky

This comment has been minimized.

Copy link

commented Mar 6, 2019

@zombieJ Thanks for the tip, remove node_modules and reinstall is valid
Thanks

@x1nGoo

This comment has been minimized.

Copy link

commented Mar 13, 2019

请问这个bug 是要更新哪个包的版本? 我的版本是 "name": "ant-design-pro", "version": "2.1.1",

@zombieJ

This comment has been minimized.

Copy link
Member Author

commented Mar 13, 2019

请问这个bug 是要更新哪个包的版本? 我的版本是 "name": "ant-design-pro", "version": "2.1.1",

更新一下 antd 版本

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.