Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Input Password focus state #15184

Merged
merged 5 commits into from Mar 5, 2019
Merged

Fix Input Password focus state #15184

merged 5 commits into from Mar 5, 2019

Conversation

@afc163
Copy link
Member

@afc163 afc163 commented Mar 4, 2019

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

馃懟 What's the background and how to resolve it?

#15173

馃挕 Solution

Preventing dom node's onMouseDown event can avoid focus state lost.

馃摑 Changelog description

  • Fixed Input.Password lost focus when change visibilityToggle. #15173
  • Fixed Input allowClear do not focus after clear content.

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed
@afc163 afc163 changed the title Fix input focus state Fix Input Password focus state Mar 4, 2019
@codecov
Copy link

@codecov codecov bot commented Mar 4, 2019

Codecov Report

Merging #15184 into master will decrease coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15184      +/-   ##
==========================================
- Coverage    93.4%   93.33%   -0.08%     
==========================================
  Files         249      249              
  Lines        6672     6675       +3     
  Branches     1946     1958      +12     
==========================================
- Hits         6232     6230       -2     
- Misses        437      442       +5     
  Partials        3        3
Impacted Files Coverage 螖
components/input/Input.tsx 100% <100%> (酶) 猬嗭笍
components/input/Password.tsx 100% <100%> (酶) 猬嗭笍
components/_util/wave.tsx 84.61% <0%> (-2.89%) 猬囷笍
components/upload/UploadList.tsx 87.15% <0%> (-1.84%) 猬囷笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update fa4ec1a...216c852. Read the comment docs.

ztplz
ztplz approved these changes Mar 4, 2019
@netlify
Copy link

@netlify netlify bot commented Mar 4, 2019

Deploy preview for ant-design ready!

Built with commit 216c852

https://deploy-preview-15184--ant-design.netlify.com

Copy link

@accesslint accesslint bot left a comment

There are accessibility issues in these changes.

components/input/__tests__/index.test.js Show resolved Hide resolved
@afc163 afc163 merged commit 5dec496 into master Mar 5, 2019
30 of 31 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix-input-focus-state branch Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants