Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update `setContentRef` ts def #15197

Merged
merged 1 commit into from Mar 5, 2019

Conversation

Projects
None yet
2 participants
@zombieJ
Copy link
Member

commented Mar 5, 2019

First of all, thank you for your contribution! 😄

New feature please send pull request to feature branch, and rest to master branch.
Pull request will be merged after one of collaborators approve.
Please makes sure that these form are filled before submitting your pull request, thank you!

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

👻 What's the background?

fix #15188

💡 Solution

UpdatesetContentRef def.

📝 Changelog description

  1. Update Typography setContentRef Typescript definition.
  2. 更新 Typography setContentRef Typescript 定义。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed
@codecov

This comment has been minimized.

Copy link

commented Mar 5, 2019

Codecov Report

Merging #15197 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #15197   +/-   ##
=======================================
  Coverage    93.6%    93.6%           
=======================================
  Files         249      249           
  Lines        6675     6675           
  Branches     1958     1926   -32     
=======================================
  Hits         6248     6248           
- Misses        424      426    +2     
+ Partials        3        1    -2
Impacted Files Coverage Δ
components/typography/Typography.tsx 100% <ø> (ø) ⬆️
components/time-picker/index.tsx 81.94% <0%> (ø) ⬆️
components/transfer/index.tsx 85.43% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f817aa9...26cde58. Read the comment docs.

1 similar comment
@codecov

This comment has been minimized.

Copy link

commented Mar 5, 2019

Codecov Report

Merging #15197 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #15197   +/-   ##
=======================================
  Coverage    93.6%    93.6%           
=======================================
  Files         249      249           
  Lines        6675     6675           
  Branches     1958     1926   -32     
=======================================
  Hits         6248     6248           
- Misses        424      426    +2     
+ Partials        3        1    -2
Impacted Files Coverage Δ
components/typography/Typography.tsx 100% <ø> (ø) ⬆️
components/time-picker/index.tsx 81.94% <0%> (ø) ⬆️
components/transfer/index.tsx 85.43% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f817aa9...26cde58. Read the comment docs.

@netlify

This comment has been minimized.

Copy link

commented Mar 5, 2019

Deploy preview for ant-design ready!

Built with commit 26cde58

https://deploy-preview-15197--ant-design.netlify.com

@afc163

This comment has been minimized.

Copy link
Member

commented Mar 5, 2019

这个属性有啥用?setContentRef

@zombieJ

This comment has been minimized.

Copy link
Member Author

commented Mar 5, 2019

这个属性有啥用?setContentRef

用来获取真实的 dom 节点,给 ellipsis 计算用的。

@afc163 afc163 merged commit 7724fee into master Mar 5, 2019

29 of 31 checks passed

Header rules No header rules processed
Details
Pages changed 12 new files uploaded
Details
AccessLint Review complete
Auto Assign Auto Assign
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
CodeFactor No issues found.
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
License Compliance All checks passed.
Details
Mixed content No mixed content detected
Details
Redirect rules 18 redirect rules processed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codebeat no reportable quality changes
Details
codecov/patch Coverage not affected when comparing f817aa9...26cde58
Details
codecov/project 93.6% remains the same compared to f817aa9
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@delete-merged-branch delete-merged-branch bot deleted the typography-ts branch Mar 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.