Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fault-tolerant processing for rowSelection.getCheckboxProps #15224

Merged
merged 2 commits into from Jun 4, 2019

Conversation

Projects
None yet
4 participants
@long-zhuge
Copy link

commented Mar 6, 2019

首先,感谢你的贡献!😄

新特性请提交至 feature 分支,其余可提交至 master 分支。
在一个维护者审核通过后合并。
请确保填写以下 pull request 的信息,谢谢!~

[English Template / 英文模板]

🤔 这个变动的性质是?

  • 新特性提交
  • 日常 bug 修复
  • 站点、文档改进
  • 组件样式改进
  • TypeScript 定义更新
  • 重构
  • 代码风格优化
  • 分支合并
  • 其他改动(是关于什么的改动?)

👻 需求背景

Table 组件的 rowSelection.getCheckboxProps() 如果没有返回对象,则会报 disabled is undefined 错误

💡 解决方案和最终实现是?

在此处做容错处理
image

📝 更新日志怎么写?

从用户角度描述具体变化,以及可能的 breaking change 和其他风险?

  1. better use of API.

☑️ 请求合并前的自查清单

  • 文档无须补充
  • 代码演示无须提供
  • TypeScript 定义无须补充
  • Changelog 无须提供
@zombieJ

This comment has been minimized.

Copy link
Member

commented Mar 6, 2019

Could you help to add test case for this?

@zombieJ zombieJ referenced this pull request Mar 6, 2019

Closed

Update index.zh-CN.md #15086

2 of 13 tasks complete
@netlify

This comment has been minimized.

Copy link

commented Mar 6, 2019

Deploy preview for ant-design ready!

Built with commit fc88005

https://deploy-preview-15224--ant-design.netlify.com

@codecov

This comment has been minimized.

Copy link

commented Mar 6, 2019

Codecov Report

Merging #15224 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15224      +/-   ##
==========================================
+ Coverage   93.63%   93.64%   +0.01%     
==========================================
  Files         249      249              
  Lines        6675     6675              
  Branches     1946     1961      +15     
==========================================
+ Hits         6250     6251       +1     
+ Misses        422      421       -1     
  Partials        3        3
Impacted Files Coverage Δ
components/table/Table.tsx 92.94% <100%> (ø) ⬆️
components/upload/UploadList.tsx 87.15% <0%> (-1.84%) ⬇️
components/_util/wave.tsx 87.5% <0%> (+2.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 074363b...fc88005. Read the comment docs.

@codecov

This comment has been minimized.

Copy link

commented Mar 6, 2019

Codecov Report

Merging #15224 into master will decrease coverage by 2.31%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15224      +/-   ##
==========================================
- Coverage   95.96%   93.64%   -2.32%     
==========================================
  Files         263      249      -14     
  Lines        7335     6675     -660     
  Branches     2007     1961      -46     
==========================================
- Hits         7039     6251     -788     
- Misses        294      421     +127     
- Partials        2        3       +1
Impacted Files Coverage Δ
components/table/Table.tsx 92.94% <100%> (-0.47%) ⬇️
components/_util/transButton.tsx 42.85% <0%> (-42.86%) ⬇️
components/modal/Modal.tsx 73.33% <0%> (-26.67%) ⬇️
components/time-picker/index.tsx 81.94% <0%> (-16.74%) ⬇️
components/card/index.tsx 84% <0%> (-16%) ⬇️
components/_util/resizeObserver.tsx 84% <0%> (-16%) ⬇️
components/auto-complete/InputElement.tsx 53.84% <0%> (-15.39%) ⬇️
components/menu/SubMenu.tsx 75% <0%> (-15%) ⬇️
components/calendar/Header.tsx 82.27% <0%> (-14.57%) ⬇️
components/modal/ActionButton.tsx 75.86% <0%> (-14.14%) ⬇️
... and 108 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a484dd...9fdc408. Read the comment docs.

@afc163

This comment has been minimized.

Copy link
Member

commented Apr 23, 2019

conflicted and need test case

@afc163
Copy link
Member

left a comment

conflicted and test case is needed

@pr-triage pr-triage bot added the PR: unreviewed label Jun 4, 2019

@afc163 afc163 merged commit 4a79384 into ant-design:master Jun 4, 2019

4 of 9 checks passed

packtracker/css Awaiting your commit report...
Details
packtracker/javascript Awaiting your commit report...
Details
Semantic Pull Request add a semantic commit or PR title
Details
ant-design.ant-design in progress
Details
ci/circleci: setup CircleCI is running your tests
Details
CodeFactor 3 issues fixed. 2 issues found.
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
WIP Ready for review
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@pr-triage pr-triage bot added the PR: merged label Jun 4, 2019

@ikobe ikobe referenced this pull request Jun 6, 2019

Merged

docs: 3.19.3 change-log #16998

1 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.