Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix when size is small and label is vertical the label text not align center #15256

Merged
merged 1 commit into from Mar 7, 2019

Conversation

Projects
None yet
2 participants
@yoyo837
Copy link
Contributor

commented Mar 7, 2019

https://codesandbox.io/s/9yk9k8kv5w

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

👻 What's the background?

  1. Describe the source of requirement, like related issue link.

  2. Describe the problem and the scenario.

💡 Solution

  1. How to fix the problem, and list final API implementation and usage sample if that is an new feature.

  2. GIF or snapshot should be provided if includes UI/interactive modification.

📝 Changelog description

Describe changes from user side, and list all potential break changes or other risks.

  1. English description

  2. Chinese description (optional)

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed
@netlify

This comment has been minimized.

Copy link

commented Mar 7, 2019

Deploy preview for ant-design ready!

Built with commit 6b84c07

https://deploy-preview-15256--ant-design.netlify.com

@codecov

This comment has been minimized.

Copy link

commented Mar 7, 2019

Codecov Report

Merging #15256 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #15256   +/-   ##
=======================================
  Coverage    93.6%    93.6%           
=======================================
  Files         249      249           
  Lines        6677     6677           
  Branches     1947     1927   -20     
=======================================
  Hits         6250     6250           
- Misses        424      426    +2     
+ Partials        3        1    -2
Impacted Files Coverage Δ
components/time-picker/index.tsx 81.94% <0%> (ø) ⬆️
components/transfer/index.tsx 85.43% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd435af...6b84c07. Read the comment docs.

2 similar comments
@codecov

This comment has been minimized.

Copy link

commented Mar 7, 2019

Codecov Report

Merging #15256 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #15256   +/-   ##
=======================================
  Coverage    93.6%    93.6%           
=======================================
  Files         249      249           
  Lines        6677     6677           
  Branches     1947     1927   -20     
=======================================
  Hits         6250     6250           
- Misses        424      426    +2     
+ Partials        3        1    -2
Impacted Files Coverage Δ
components/time-picker/index.tsx 81.94% <0%> (ø) ⬆️
components/transfer/index.tsx 85.43% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd435af...6b84c07. Read the comment docs.

@codecov

This comment has been minimized.

Copy link

commented Mar 7, 2019

Codecov Report

Merging #15256 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #15256   +/-   ##
=======================================
  Coverage    93.6%    93.6%           
=======================================
  Files         249      249           
  Lines        6677     6677           
  Branches     1947     1927   -20     
=======================================
  Hits         6250     6250           
- Misses        424      426    +2     
+ Partials        3        1    -2
Impacted Files Coverage Δ
components/time-picker/index.tsx 81.94% <0%> (ø) ⬆️
components/transfer/index.tsx 85.43% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd435af...6b84c07. Read the comment docs.

@afc163 afc163 merged commit 65b69b7 into ant-design:master Mar 7, 2019

26 of 28 checks passed

Header rules No header rules processed
Details
Pages changed 13 new files uploaded
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
CodeFactor No issues found.
Details
LGTM analysis: JavaScript No code changes detected
Details
Mixed content No mixed content detected
Details
Redirect rules 18 redirect rules processed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codebeat no reportable quality changes
Details
codecov/patch Coverage not affected when comparing dd435af...6b84c07
Details
codecov/project 93.6% remains the same compared to dd435af
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@yoyo837 yoyo837 deleted the yoyo837:fix-steps-label-align branch Mar 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.