Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep same content color of List like previous version #15301

Merged
merged 1 commit into from Mar 10, 2019

Conversation

Projects
None yet
1 participant
@afc163
Copy link
Member

afc163 commented Mar 9, 2019

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

馃懟 What's the background?

  1. Describe the source of requirement, like related issue link.

close #15296

  1. Describe the problem and the scenario.

馃挕 Solution

Add text color to content.

馃摑 Changelog description

Describe changes from user side, and list all potential break changes or other risks.

  1. English description
  • Keep same content color of List like previous version. #15296
  1. Chinese description (optional)

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed
@codecov

This comment has been minimized.

Copy link

codecov bot commented Mar 9, 2019

Codecov Report

Merging #15301 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15301      +/-   ##
==========================================
+ Coverage   94.13%   94.15%   +0.01%     
==========================================
  Files         250      250              
  Lines        6635     6635              
  Branches     1906     1906              
==========================================
+ Hits         6246     6247       +1     
+ Misses        388      387       -1     
  Partials        1        1
Impacted Files Coverage 螖
components/upload/UploadList.tsx 94.49% <0%> (-1.84%) 猬囷笍
components/_util/wave.tsx 87.5% <0%> (+2.88%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 75a2038...4275430. Read the comment docs.

@netlify

This comment has been minimized.

Copy link

netlify bot commented Mar 9, 2019

Deploy preview for ant-design ready!

Built with commit 4275430

https://deploy-preview-15301--ant-design.netlify.com

@afc163 afc163 merged commit c4473e3 into master Mar 10, 2019

24 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
CodeFactor No issues found.
Details
LGTM analysis: JavaScript No code changes detected
Details
License Compliance All checks passed.
Details
ant-design.ant-design #ant design succeeded
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codebeat no reportable quality changes
Details
codecov/patch Coverage not affected when comparing 75a2038...4275430
Details
codecov/project 94.15% (+0.01%) compared to 75a2038
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@delete-merged-branch delete-merged-branch bot deleted the fix-list-content-color branch Mar 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.