Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:add style prop for Steps.Step component #15393

Merged
merged 1 commit into from Mar 14, 2019

Conversation

Projects
None yet
2 participants
@DiamondYuan
Copy link
Collaborator

commented Mar 14, 2019

First of all, thank you for your contribution! 😄

New feature please send pull request to feature branch, and rest to master branch.
Pull request will be merged after one of collaborators approve.
Please makes sure that these form are filled before submitting your pull request, thank you!

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

👻 What's the background?

close #15358

📝 Changelog description

Describe changes from userside, and list all potential break changes or other risks.

  1. English description
    fix:add style prop for Steps.Step component
  2. Chinese description (optional)
    step 组件类型文件 增加 style

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed
@netlify

This comment has been minimized.

Copy link

commented Mar 14, 2019

Deploy preview for ant-design ready!

Built with commit 1ff0be5

https://deploy-preview-15393--ant-design.netlify.com

@DiamondYuan DiamondYuan requested a review from afc163 Mar 14, 2019

@codecov

This comment has been minimized.

Copy link

commented Mar 14, 2019

Codecov Report

Merging #15393 into master will increase coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15393      +/-   ##
==========================================
+ Coverage   94.23%   94.35%   +0.11%     
==========================================
  Files         250      250              
  Lines        6645     6640       -5     
  Branches     1943     1938       -5     
==========================================
+ Hits         6262     6265       +3     
+ Misses        382      374       -8     
  Partials        1        1
Impacted Files Coverage Δ
components/steps/index.tsx 100% <ø> (ø) ⬆️
components/upload/UploadList.tsx 96.33% <0%> (+1.83%) ⬆️
components/avatar/index.tsx 96.29% <0%> (+9.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98b10a7...1ff0be5. Read the comment docs.

@afc163 afc163 merged commit 167f54b into ant-design:master Mar 14, 2019

26 of 28 checks passed

Header rules No header rules processed
Details
Pages changed 82 new files uploaded
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
CodeFactor No issues found.
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
Mixed content No mixed content detected
Details
Redirect rules 18 redirect rules processed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codebeat 1 issue resolved and 0 introduced
Details
codecov/patch Coverage not affected when comparing 98b10a7...1ff0be5
Details
codecov/project 94.35% (+0.11%) compared to 98b10a7
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.