Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Independent btn styles #15397

Merged
merged 2 commits into from Mar 15, 2019

Conversation

Projects
None yet
3 participants
@searleb
Copy link
Contributor

commented Mar 14, 2019

First of all, thank you for your contribution! 😄

New feature please send pull request to feature branch, and rest to master branch.
Pull request will be merged after one of collaborators approve.
Please makes sure that these form are filled before submitting your pull request, thank you!

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

👻 What's the background?

  1. Describe the source of requirement, like related issue link.
    Edit theme variables for button border width and style independently from border-base styles.

  2. Describe the problem and the scenario.
    Not able to edit the button border through variables separately from all component border styles.

💡 Solution

  1. How to fix the problem, and list final API implementation and usage sample if that is an new feature.
    Added two new variables:
  • @btn-border-width
  • @btn-border-style
    which default to their base style counterpart
  1. GIF or snapshot should be provided if includes UI/interactive modification.

📝 Changelog description

Describe changes from userside, and list all potential break changes or other risks.

  1. English description
    Added @btn-border-width and @btn-border-style Less variables.

  2. Chinese description (optional)

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

searleb added some commits Mar 14, 2019

@netlify

This comment has been minimized.

Copy link

commented Mar 14, 2019

Deploy preview for ant-design ready!

Built with commit ffc5321

https://deploy-preview-15397--ant-design.netlify.com

@codecov

This comment has been minimized.

Copy link

commented Mar 14, 2019

Codecov Report

Merging #15397 into feature will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           feature   #15397      +/-   ##
===========================================
+ Coverage     94.1%   94.15%   +0.04%     
===========================================
  Files          250      250              
  Lines         6635     6635              
  Branches      1906     1938      +32     
===========================================
+ Hits          6244     6247       +3     
+ Misses         390      387       -3     
  Partials         1        1
Impacted Files Coverage Δ
components/_util/wave.tsx 87.5% <0%> (+2.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 102c342...ffc5321. Read the comment docs.

@codecov

This comment has been minimized.

Copy link

commented Mar 14, 2019

Codecov Report

Merging #15397 into feature will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           feature   #15397      +/-   ##
===========================================
+ Coverage    94.13%   94.15%   +0.01%     
===========================================
  Files          250      250              
  Lines         6635     6635              
  Branches      1906     1938      +32     
===========================================
+ Hits          6246     6247       +1     
+ Misses         388      387       -1     
  Partials         1        1
Impacted Files Coverage Δ
components/upload/UploadList.tsx 94.49% <0%> (-1.84%) ⬇️
components/_util/wave.tsx 87.5% <0%> (+2.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 102c342...ffc5321. Read the comment docs.

@afc163

afc163 approved these changes Mar 15, 2019

@ztplz

ztplz approved these changes Mar 15, 2019

@afc163 afc163 merged commit 9b8126c into ant-design:feature Mar 15, 2019

25 of 27 checks passed

Header rules No header rules processed
Details
Pages changed 18 new files uploaded
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
LGTM analysis: JavaScript No code changes detected
Details
Mixed content No mixed content detected
Details
Redirect rules 18 redirect rules processed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codebeat Target branch is not tracked
Details
codecov/patch Coverage not affected when comparing 102c342...ffc5321
Details
codecov/project 94.15% (+0.01%) compared to 102c342
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@afc163 afc163 referenced this pull request Mar 17, 2019

Merged

docs: add changelog for 3.15.1 #15455

1 of 13 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.