Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change type of PaginationProps.itemRender originalElement param #15428

Merged
merged 1 commit into from Mar 15, 2019

Conversation

Projects
None yet
2 participants
@DiamondYuan
Copy link
Collaborator

DiamondYuan commented Mar 15, 2019

First of all, thank you for your contribution! 😄

New feature please send pull request to feature branch, and rest to master branch.
Pull request will be merged after one of collaborators approve.
Please makes sure that these form are filled before submitting your pull request, thank you!

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

👻 What's the background?

close #15384

📝 Changelog description

Describe changes from userside, and list all potential break changes or other risks.

  1. English description
    change type of PaginationProps.itemRender originalElement param
  2. Chinese description (optional)

修复 PaginationProps 组件 itemRender 函数的类型错误

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed
@netlify

This comment has been minimized.

Copy link

netlify bot commented Mar 15, 2019

Deploy preview for ant-design ready!

Built with commit eecc29d

https://deploy-preview-15428--ant-design.netlify.com

@codecov

This comment has been minimized.

Copy link

codecov bot commented Mar 15, 2019

Codecov Report

Merging #15428 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #15428   +/-   ##
=======================================
  Coverage   94.19%   94.19%           
=======================================
  Files         250      250           
  Lines        6647     6647           
  Branches     1942     1944    +2     
=======================================
  Hits         6261     6261           
  Misses        385      385           
  Partials        1        1
Impacted Files Coverage Δ
components/pagination/Pagination.tsx 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df47224...eecc29d. Read the comment docs.

1 similar comment
@codecov

This comment has been minimized.

Copy link

codecov bot commented Mar 15, 2019

Codecov Report

Merging #15428 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #15428   +/-   ##
=======================================
  Coverage   94.19%   94.19%           
=======================================
  Files         250      250           
  Lines        6647     6647           
  Branches     1942     1944    +2     
=======================================
  Hits         6261     6261           
  Misses        385      385           
  Partials        1        1
Impacted Files Coverage Δ
components/pagination/Pagination.tsx 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df47224...eecc29d. Read the comment docs.

@afc163 afc163 merged commit e052031 into ant-design:master Mar 15, 2019

23 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
CodeFactor No issues found.
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
ant-design.ant-design #ant design succeeded
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codebeat no reportable quality changes
Details
codecov/patch Coverage not affected when comparing df47224...eecc29d
Details
codecov/project 94.19% remains the same compared to df47224
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.