Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Menu): add overflowedIndicator prop #15459

Merged
merged 1 commit into from Mar 17, 2019

Conversation

Projects
None yet
2 participants
@Yangzhedi
Copy link
Contributor

commented Mar 17, 2019

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

馃懟 What's the background?

#15439

馃挕 Solution

  1. How to fix the problem, and list final API implementation and usage sample if that is an new feature.

  2. GIF or snapshot should be provided if includes UI/interactive modification.

馃摑 Changelog description

Describe changes from userside, and list all potential break changes or other risks.

  1. English description

  2. Chinese description (optional)

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed
@netlify

This comment has been minimized.

Copy link

commented Mar 17, 2019

Deploy preview for ant-design ready!

Built with commit dd32552

https://deploy-preview-15459--ant-design.netlify.com

@codecov

This comment has been minimized.

Copy link

commented Mar 17, 2019

Codecov Report

Merging #15459 into feature will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           feature   #15459      +/-   ##
===========================================
- Coverage    94.15%    94.1%   -0.05%     
===========================================
  Files          250      250              
  Lines         6635     6635              
  Branches      1938     1926      -12     
===========================================
- Hits          6247     6244       -3     
- Misses         387      390       +3     
  Partials         1        1
Impacted Files Coverage 螖
components/menu/index.tsx 90.9% <酶> (酶) 猬嗭笍
components/_util/wave.tsx 84.61% <0%> (-2.89%) 猬囷笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 9b8126c...dd32552. Read the comment docs.

1 similar comment
@codecov

This comment has been minimized.

Copy link

commented Mar 17, 2019

Codecov Report

Merging #15459 into feature will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           feature   #15459      +/-   ##
===========================================
- Coverage    94.15%    94.1%   -0.05%     
===========================================
  Files          250      250              
  Lines         6635     6635              
  Branches      1938     1926      -12     
===========================================
- Hits          6247     6244       -3     
- Misses         387      390       +3     
  Partials         1        1
Impacted Files Coverage 螖
components/menu/index.tsx 90.9% <酶> (酶) 猬嗭笍
components/_util/wave.tsx 84.61% <0%> (-2.89%) 猬囷笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 9b8126c...dd32552. Read the comment docs.

@afc163

afc163 approved these changes Mar 17, 2019

@afc163 afc163 merged commit 68c6982 into ant-design:feature Mar 17, 2019

25 of 27 checks passed

Header rules No header rules processed
Details
Pages changed 20 new files uploaded
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
Mixed content No mixed content detected
Details
Redirect rules 18 redirect rules processed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codebeat Target branch is not tracked
Details
codecov/patch Coverage not affected when comparing 9b8126c...dd32552
Details
codecov/project 94.1% (-0.05%) compared to 9b8126c
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@Yangzhedi Yangzhedi deleted the Yangzhedi:feat-menu-overflowedIndicator branch Mar 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.