Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Menu): add overflowedIndicator prop #15459

Merged
merged 1 commit into from Mar 17, 2019

Conversation

@Yangzhedi
Copy link
Contributor

@Yangzhedi Yangzhedi commented Mar 17, 2019

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

馃懟 What's the background?

#15439

馃挕 Solution

  1. How to fix the problem, and list final API implementation and usage sample if that is an new feature.

  2. GIF or snapshot should be provided if includes UI/interactive modification.

馃摑 Changelog description

Describe changes from userside, and list all potential break changes or other risks.

  1. English description

  2. Chinese description (optional)

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed
@netlify
Copy link

@netlify netlify bot commented Mar 17, 2019

Deploy preview for ant-design ready!

Built with commit dd32552

https://deploy-preview-15459--ant-design.netlify.com

@codecov
Copy link

@codecov codecov bot commented Mar 17, 2019

Codecov Report

Merging #15459 into feature will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           feature   #15459      +/-   ##
===========================================
- Coverage    94.15%    94.1%   -0.05%     
===========================================
  Files          250      250              
  Lines         6635     6635              
  Branches      1938     1926      -12     
===========================================
- Hits          6247     6244       -3     
- Misses         387      390       +3     
  Partials         1        1
Impacted Files Coverage 螖
components/menu/index.tsx 90.9% <酶> (酶) 猬嗭笍
components/_util/wave.tsx 84.61% <0%> (-2.89%) 猬囷笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 9b8126c...dd32552. Read the comment docs.

1 similar comment
@codecov
Copy link

@codecov codecov bot commented Mar 17, 2019

Codecov Report

Merging #15459 into feature will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           feature   #15459      +/-   ##
===========================================
- Coverage    94.15%    94.1%   -0.05%     
===========================================
  Files          250      250              
  Lines         6635     6635              
  Branches      1938     1926      -12     
===========================================
- Hits          6247     6244       -3     
- Misses         387      390       +3     
  Partials         1        1
Impacted Files Coverage 螖
components/menu/index.tsx 90.9% <酶> (酶) 猬嗭笍
components/_util/wave.tsx 84.61% <0%> (-2.89%) 猬囷笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 9b8126c...dd32552. Read the comment docs.

afc163
afc163 approved these changes Mar 17, 2019
@afc163 afc163 merged commit 68c6982 into ant-design:feature Mar 17, 2019
27 checks passed
@Yangzhedi Yangzhedi deleted the feat-menu-overflowedIndicator branch Mar 17, 2019
@zsbox
Copy link

@zsbox zsbox commented Aug 19, 2020

鎬庝箞鐢ㄧ殑鍟婏紵

@ghost
Copy link

@ghost ghost commented Aug 20, 2020

鎬庝箞鐢ㄥ晩 锛 涔熶笉璇 鍙啓浼燿om 杩欐槸vue鍟婏紝鏄笉鏄鐢╮ender娓叉煋鍟
鏂囨。楹荤儲鍐欒缁嗙偣 濂藉浼犵殑绫诲瀷閮戒笉鍐 涓涓竴涓緱鐚滐紝鏂囨。瀛﹀element濂戒笉

@kerm1it
Copy link
Member

@kerm1it kerm1it commented Aug 21, 2020

ReactNode 鏄 React 鐨勭被鍨嬪0鏄庢枃浠堕噷闈㈡彁渚涚殑绫诲瀷瀹氫箟锛屼唬琛 React 娓叉煋鐨勮妭鐐癸紝瀹冨彲浠ユ槸 DOM銆stringnumberboolean 绛夛紝 鍏蜂綋闇瑕佸幓鏌ョ湅绫诲瀷澹版槑銆

image

@L924553229
Copy link

@L924553229 L924553229 commented Dec 17, 2020

  1. 鐩存帴鏀剧疆 import image 涓嶅彲浠;
  2. 涓嶅彲浠;
  3. 鏀惧湪submenu 涓嶅彲浠;
    4.........

@kerm1it
Copy link
Member

@kerm1it kerm1it commented Dec 17, 2020

  1. 鐩存帴鏀剧疆 import image 涓嶅彲浠;

  2. 涓嶅彲浠;

  3. 鏀惧湪submenu 涓嶅彲浠;

4.........

楹荤儲鎻忚堪娓呮锛岀粰澶嶇幇绀轰緥銆

@L924553229
Copy link

@L924553229 L924553229 commented Dec 18, 2020

鐩存帴鏀剧疆 import image 涓嶅彲浠;

涓嶅彲浠;

鏀惧湪submenu 涓嶅彲浠;

4.........
楹荤儲鎻忚堪娓呮锛岀粰澶嶇幇绀轰緥銆

import Image from './a.png';
鏂规硶涓:
export default const componentA = () => {
return(


<Menu.Item>鑿滃崟椤</Menu.Item>

<Menu.Item>瀛愯彍鍗曢」</Menu.Item>

); } 鏂规硶浜: export default const componentA = () => { return( } > 鑿滃崟椤 瀛愯彍鍗曢」 ); }

@kerm1it
Copy link
Member

@kerm1it kerm1it commented Dec 18, 2020

鍥剧墖瀵艰繘鏉ュ悗鏄矾寰勬垨鑰 base64锛岄渶瑕佽祴鍊肩粰 imgsrc 灞炴э紝杩欓噷闇瑕佺殑绫诲瀷鏄: #15459 (comment)

https://u.ant.design/codesandbox-repro 鐢ㄨ繖涓摼鎺ュ啓涓緥瀛愶紝鎴戣繕鍙互甯綘鏀规敼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants