Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal footer bg #15469

Merged
merged 5 commits into from Mar 18, 2019
Merged

Modal footer bg #15469

merged 5 commits into from Mar 18, 2019

Conversation

@shumkovdenis
Copy link
Contributor

@shumkovdenis shumkovdenis commented Mar 17, 2019

First of all, thank you for your contribution! πŸ˜„

New feature please send pull request to feature branch, and rest to master branch.
Pull request will be merged after one of collaborators approve.
Please makes sure that these form are filled before submitting your pull request, thank you!

[δΈ­ζ–‡η‰ˆζ¨‘ζΏ / Chinese template]

πŸ€” This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

πŸ‘» What's the background?

  1. Describe the source of requirement, like related issue link.

  2. Describe the problem and the scenario.

πŸ’‘ Solution

  1. How to fix the problem, and list final API implementation and usage sample if that is an new feature.

  2. GIF or snapshot should be provided if includes UI/interactive modification.

πŸ“ Changelog description

Describe changes from userside, and list all potential break changes or other risks.

  1. English description
  • Add less variable @modal-footer-bg.
  1. Chinese description (optional)

β˜‘οΈ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed
@netlify
Copy link

@netlify netlify bot commented Mar 17, 2019

Deploy preview for ant-design ready!

Built with commit 89f90be

https://deploy-preview-15469--ant-design.netlify.com

@afc163
Copy link
Member

@afc163 afc163 commented Mar 18, 2019

image

@shumkovdenis shumkovdenis changed the base branch from master to feature Mar 18, 2019
@codecov
Copy link

@codecov codecov bot commented Mar 18, 2019

Codecov Report

Merging #15469 into feature will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           feature   #15469   +/-   ##
========================================
  Coverage    94.15%   94.15%           
========================================
  Files          250      250           
  Lines         6643     6643           
  Branches      1911     1911           
========================================
  Hits          6255     6255           
  Misses         387      387           
  Partials         1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 360eefc...89f90be. Read the comment docs.

components/style/themes/default.less Outdated Show resolved Hide resolved
afc163 and others added 2 commits Mar 18, 2019
afc163
afc163 approved these changes Mar 18, 2019
@zombieJ zombieJ merged commit eacf35d into ant-design:feature Mar 18, 2019
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants