Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 Fix Select notFound align issue #15570

Merged
merged 1 commit into from Mar 22, 2019

Conversation

Projects
None yet
3 participants
@afc163
Copy link
Member

commented Mar 21, 2019

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

馃懟 What's the background?

close #15567

image

close #14422 again

image

馃挕 Solution

灞忓箷蹇収 2019-03-21 涓嬪崍5 14 09

馃摑 Changelog description

Describe changes from userside, and list all potential break changes or other risks.

  1. English description
  • 馃悰 Fix Select notFound content wrong align. #15567 #14422
  1. Chinese description (optional)

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@afc163 afc163 changed the title :bug: Fix Select notFound align issue 馃悰 Fix Select notFound align issue Mar 21, 2019

@afc163 afc163 force-pushed the fix-not-found-style branch from 8834f91 to ca08411 Mar 21, 2019

@codecov

This comment has been minimized.

Copy link

commented Mar 21, 2019

Codecov Report

Merging #15570 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #15570   +/-   ##
=======================================
  Coverage   94.45%   94.45%           
=======================================
  Files         250      250           
  Lines        6650     6650           
  Branches     1911     1932   +21     
=======================================
  Hits         6281     6281           
  Misses        368      368           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 4eb33eb...ca08411. Read the comment docs.

@netlify

This comment has been minimized.

Copy link

commented Mar 21, 2019

Deploy preview for ant-design failed.

Built with commit 8834f91

https://app.netlify.com/sites/ant-design/deploys/5c9356c3f1036c000712d536

@netlify

This comment has been minimized.

Copy link

commented Mar 21, 2019

Deploy preview for ant-design ready!

Built with commit ca08411

https://deploy-preview-15570--ant-design.netlify.com

@ztplz

ztplz approved these changes Mar 21, 2019

@dengfuping dengfuping merged commit 7c7c619 into master Mar 22, 2019

28 of 30 checks passed

Header rules No header rules processed
Details
Pages changed 13 new files uploaded
Details
Auto Assign Auto Assign
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
CodeFactor No issues found.
Details
LGTM analysis: JavaScript No code changes detected
Details
Mixed content No mixed content detected
Details
Redirect rules 18 redirect rules processed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize No significant change
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codebeat no reportable quality changes
Details
codecov/patch Coverage not affected when comparing 4eb33eb...ca08411
Details
codecov/project 94.45% remains the same compared to 4eb33eb
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@delete-merged-branch delete-merged-branch bot deleted the fix-not-found-style branch Mar 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.