Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(form-item): move `ant-form-item-no-colon` selector position #15592

Merged
merged 2 commits into from Mar 24, 2019

Conversation

Projects
None yet
2 participants
@hsuanxyz
Copy link
Contributor

commented Mar 22, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

👻 What's the background?

  1. Describe the source of requirement, like related issue link.
    #15585
  2. Describe the problem and the scenario.
    #15585

💡 Solution

  1. How to fix the problem, and list final API implementation and usage sample if that is an new feature.

  2. GIF or snapshot should be provided if includes UI/interactive modification.

📝 Changelog description

Describe changes from userside, and list all potential break changes or other risks.

  1. English description
    Refactor move ant-form-item-no-colon selector position in Form.Item
  2. Chinese description (optional)
    重构 移动 Form.Itemant-form-item-no-colon 选择器的位置

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed
@netlify

This comment has been minimized.

Copy link

commented Mar 22, 2019

Deploy preview for ant-design ready!

Built with commit 05150e7

https://deploy-preview-15592--ant-design.netlify.com

@codecov

This comment has been minimized.

Copy link

commented Mar 22, 2019

Codecov Report

Merging #15592 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15592      +/-   ##
==========================================
- Coverage   94.45%   94.44%   -0.01%     
==========================================
  Files         250      250              
  Lines        6649     6647       -2     
  Branches     1910     1910              
==========================================
- Hits         6280     6278       -2     
  Misses        368      368              
  Partials        1        1
Impacted Files Coverage Δ
components/form/FormItem.tsx 98.85% <100%> (-0.02%) ⬇️
components/table/Table.tsx 92.97% <0%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e0aa5c...05150e7. Read the comment docs.

@codecov

This comment has been minimized.

Copy link

commented Mar 22, 2019

Codecov Report

Merging #15592 into master will decrease coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15592      +/-   ##
==========================================
- Coverage   94.49%   94.44%   -0.05%     
==========================================
  Files         250      250              
  Lines        6649     6647       -2     
  Branches     1910     1910              
==========================================
- Hits         6283     6278       -5     
- Misses        365      368       +3     
  Partials        1        1
Impacted Files Coverage Δ
components/form/FormItem.tsx 98.85% <100%> (-0.02%) ⬇️
components/_util/wave.tsx 84.61% <0%> (-2.89%) ⬇️
components/table/Table.tsx 92.97% <0%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e0aa5c...05150e7. Read the comment docs.

@afc163 afc163 merged commit baa5a79 into ant-design:master Mar 24, 2019

26 of 29 checks passed

codebeat 0 issues resolved and 1 introduced
Details
Header rules No header rules processed
Details
Pages changed 12 new files uploaded
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
CodeFactor No issues found.
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
Mixed content No mixed content detected
Details
Redirect rules 18 redirect rules processed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize No change
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 94.49%)
Details
codecov/project Absolute coverage decreased by -0.04% but relative coverage increased by +5.5% compared to 9e0aa5c
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No new issues
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.