Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Input): fix password prop action #15598

Merged
merged 2 commits into from Mar 24, 2019

Conversation

Projects
None yet
3 participants
@Yangzhedi
Copy link
Contributor

commented Mar 22, 2019

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

馃懟 What's the background?

fix#15587

馃挕 Solution

  1. How to fix the problem, and list final API implementation and usage sample if that is an new feature.

  2. GIF or snapshot should be provided if includes UI/interactive modification.

馃摑 Changelog description

Describe changes from userside, and list all potential break changes or other risks.

  1. English description

  2. Chinese description (optional)

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed
@netlify

This comment has been minimized.

Copy link

commented Mar 22, 2019

Deploy preview for ant-design ready!

Built with commit 9681f18

https://deploy-preview-15598--ant-design.netlify.com

@codecov

This comment has been minimized.

Copy link

commented Mar 22, 2019

Codecov Report

Merging #15598 into master will decrease coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15598      +/-   ##
==========================================
- Coverage   94.49%   94.45%   -0.05%     
==========================================
  Files         250      250              
  Lines        6649     6649              
  Branches     1910     1945      +35     
==========================================
- Hits         6283     6280       -3     
- Misses        365      368       +3     
  Partials        1        1
Impacted Files Coverage 螖
components/input/Password.tsx 100% <100%> (酶) 猬嗭笍
components/_util/wave.tsx 84.61% <0%> (-2.89%) 猬囷笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 9e0aa5c...9681f18. Read the comment docs.

@ztplz

ztplz approved these changes Mar 22, 2019

@@ -37,7 +37,7 @@ export default class Password extends React.Component<PasswordProps, PasswordSta
};

getIcon() {
const { prefixCls, action } = this.props;
const { prefixCls, action = 'click' } = this.props;

This comment has been minimized.

Copy link
@ztplz

ztplz Mar 22, 2019

Collaborator

杩欎釜娌″繀瑕 defaultProps灏辨槸click

This comment has been minimized.

Copy link
@Yangzhedi

Yangzhedi Mar 22, 2019

Author Contributor

涓嶅姞杩欎釜锛屼笅闈㈢殑ActionMap鎻愬彇鏃讹紝ts浼氭姤閿

This comment has been minimized.

Copy link
@ztplz

ztplz Mar 22, 2019

Collaborator

鍔犱釜闈炵┖鏂█ 鏈潵defaultProps灏卞凡缁忚缃簡 鍙堥噸澶嶈祴鍊间簡涓娆 鐪嬭捣鏉ヤ笉鏄緢濂

@afc163 afc163 merged commit a6a5e06 into ant-design:master Mar 24, 2019

27 of 29 checks passed

Header rules No header rules processed
Details
Pages changed 16 new files uploaded
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
CodeFactor No issues found.
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
Mixed content No mixed content detected
Details
Redirect rules 18 redirect rules processed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize No change
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codebeat no reportable quality changes
Details
codecov/patch 100% of diff hit (target 94.49%)
Details
codecov/project Absolute coverage decreased by -0.04% but relative coverage increased by +5.5% compared to 9e0aa5c
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.