Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added HR_hr locale #15641

Closed
wants to merge 7 commits into from

Conversation

Projects
None yet
4 participants
@fpintaric
Copy link

commented Mar 25, 2019

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

馃懟 What's the background?

  1. Describe the source of requirement, like related issue link.
    Added Croatian locale.

  2. Describe the problem and the scenario.
    Added Croatian locale.

馃挕 Solution

  1. How to fix the problem, and list final API implementation and usage sample if that is an new feature.
    Added needed hr_HR locale files and proper Croatian translations in them.

馃摑 Changelog description

Describe changes from userside, and list all potential break changes or other risks.

  1. English description
    Users can now use Croatian locale (hr_HR)

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Yangzhedi and others added some commits Mar 24, 2019

fix(Input): fix password prop action (#15598)
* fix(Input): fix password prop action

* fix(InputPassword): add assert action is non-null
refactor(form-item): move `ant-form-item-no-colon` selector position (#鈥
鈥15592)

* refactor(form-item): better `ant-form-item-no-colon` selector position

fix: fix lint

close #15585

* chore: update snap
Franjo

@fpintaric fpintaric changed the title Hr hr locale Added HR_hr locale Mar 25, 2019

@netlify

This comment has been minimized.

Copy link

commented Mar 25, 2019

Deploy preview for ant-design ready!

Built with commit d3a7d04

https://deploy-preview-15641--ant-design.netlify.com

Franjo

@fpintaric fpintaric closed this Mar 25, 2019

Franjo

@fpintaric fpintaric reopened this Mar 26, 2019

@codecov

This comment has been minimized.

Copy link

commented Mar 26, 2019

Codecov Report

Merging #15641 into feature will decrease coverage by 0.03%.
The diff coverage is 77.77%.

Impacted file tree graph

@@             Coverage Diff             @@
##           feature   #15641      +/-   ##
===========================================
- Coverage    94.45%   94.41%   -0.04%     
===========================================
  Files          250      252       +2     
  Lines         6669     6648      -21     
  Branches      1914     1942      +28     
===========================================
- Hits          6299     6277      -22     
- Misses         369      370       +1     
  Partials         1        1
Impacted Files Coverage 螖
components/date-picker/locale/hr_HR.tsx 0% <0%> (酶)
components/time-picker/locale/hr_HR.tsx 0% <0%> (酶)
components/form/FormItem.tsx 98.85% <100%> (-0.02%) 猬囷笍
components/input/Password.tsx 100% <100%> (酶) 猬嗭笍
components/empty/index.tsx 94.11% <0%> (-0.62%) 猬囷笍
components/config-provider/renderEmpty.tsx 86.66% <0%> (酶) 猬嗭笍
components/modal/confirm.tsx 96.29% <0%> (酶) 猬嗭笍
components/menu/index.tsx 91.42% <0%> (酶) 猬嗭笍
components/progress/progress.tsx 91.66% <0%> (酶) 猬嗭笍
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 1e8d3ce...d3a7d04. Read the comment docs.

@fpintaric

This comment has been minimized.

Copy link
Author

commented Mar 27, 2019

Checks fail on some random stuff, also on snapshots because I added a new language at 'supported languages' part in localization, anything I did wrong and can fix to pass the tests?

@afc163 afc163 referenced this pull request Apr 23, 2019

Merged

feat: 馃嚟馃嚪 hr_HR locale #16258

5 of 14 tasks complete
@afc163

This comment has been minimized.

Copy link
Member

commented Apr 24, 2019

Thx @fpintaric , merged in #16258

@afc163 afc163 closed this Apr 24, 2019

@pr-triage pr-triage bot added the PR: unreviewed label Apr 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.