Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clear icon style #15672

Merged
merged 3 commits into from Mar 26, 2019

Conversation

Projects
None yet
1 participant
@afc163
Copy link
Member

commented Mar 26, 2019

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

馃懟 What's the background?

#15237 (comment)

馃挕 Solution

Problem After Fix
灞忓箷蹇収 2019-03-26 涓嬪崍10 10 40 灞忓箷蹇収 2019-03-26 涓嬪崍10 35 35

馃摑 Changelog description

Describe changes from userside, and list all potential break changes or other risks.

  1. English description
  • 馃悰 Fix clear icon style in Input and Input.Search. #15237
  1. Chinese description (optional)

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

afc163 added some commits Mar 26, 2019

@netlify

This comment has been minimized.

Copy link

commented Mar 26, 2019

Deploy preview for ant-design ready!

Built with commit e3559ff

https://deploy-preview-15672--ant-design.netlify.com

@codecov

This comment has been minimized.

Copy link

commented Mar 26, 2019

Codecov Report

Merging #15672 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #15672   +/-   ##
=======================================
  Coverage   95.06%   95.06%           
=======================================
  Files         250      250           
  Lines        6643     6643           
  Branches     1928     1940   +12     
=======================================
  Hits         6315     6315           
  Misses        327      327           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update a3cfbb1...e3559ff. Read the comment docs.

@afc163 afc163 merged commit c3709d5 into master Mar 26, 2019

28 of 31 checks passed

Codacy/PR Quality Review Hang in there, Codacy is reviewing your Pull request.
Details
Header rules No header rules processed
Details
Pages changed 12 new files uploaded
Details
Auto Assign Auto Assign
Details
CodeFactor No issues found.
Details
LGTM analysis: JavaScript No code changes detected
Details
License Compliance All checks passed.
Details
Mixed content No mixed content detected
Details
Redirect rules 18 redirect rules processed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize No change
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codebeat no reportable quality changes
Details
codecov/patch Coverage not affected when comparing a3cfbb1...e3559ff
Details
codecov/project 95.06% remains the same compared to a3cfbb1
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@delete-merged-branch delete-merged-branch bot deleted the fix-clear-icon-style branch Mar 26, 2019

zkwolf referenced this pull request in vueComponent/ant-design-vue Apr 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.