Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: MenuItem should not render Tooltip when inlineCollapsed is false #15705

Merged
merged 1 commit into from Mar 30, 2019

Conversation

Projects
None yet
2 participants
@zy410419243
Copy link
Contributor

commented Mar 28, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

👻 What's the background?

  1. Describe the source of requirement, like related issue link.

    Related to #15625 (comment)

  2. Describe the problem and the scenario.

💡 Solution

  1. How to fix the problem, and list final API implementation and usage sample if that is an new feature.

  2. GIF or snapshot should be provided if includes UI/interactive modification.

📝 Changelog description

Describe changes from userside, and list all potential break changes or other risks.

  1. English description

    Fix MenuItem rendered unexpected Tooltip when inlineCollapsed is false.

  2. Chinese description (optional)

    修复 MenuItem 在非 inlineCollapsed 时显示了多余 Tooltip 的问题。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed
@netlify

This comment has been minimized.

Copy link

commented Mar 28, 2019

Deploy preview for ant-design ready!

Built with commit ae8b52c

https://deploy-preview-15705--ant-design.netlify.com

@codecov

This comment has been minimized.

Copy link

commented Mar 28, 2019

Codecov Report

Merging #15705 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15705      +/-   ##
==========================================
+ Coverage   95.06%    95.1%   +0.04%     
==========================================
  Files         250      250              
  Lines        6643     6641       -2     
  Branches     1907     1939      +32     
==========================================
+ Hits         6315     6316       +1     
+ Misses        327      324       -3     
  Partials        1        1
Impacted Files Coverage Δ
components/menu/MenuItem.tsx 71.42% <100%> (-6.35%) ⬇️
components/_util/wave.tsx 88.46% <0%> (+2.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0b68f9...ae8b52c. Read the comment docs.

@buildsize

This comment has been minimized.

Copy link

commented Mar 28, 2019

File name Previous Size New Size Change
package-lock.json [new file] 799.01 KB

@afc163 afc163 merged commit 25fb4a2 into ant-design:master Mar 30, 2019

27 of 29 checks passed

Header rules No header rules processed
Details
Pages changed 79 new files uploaded
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
CodeFactor No issues found.
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
Mixed content No mixed content detected
Details
Redirect rules 18 redirect rules processed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize No change
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codebeat no reportable quality changes
Details
codecov/patch 100% of diff hit (target 95.06%)
Details
codecov/project 95.1% (+0.04%) compared to d0b68f9
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@zy410419243 zy410419243 deleted the zy410419243:issue-15625 branch Mar 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.