Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add separator prop for RangePicker #15765

Merged
merged 2 commits into from Mar 31, 2019
Merged

Add separator prop for RangePicker #15765

merged 2 commits into from Mar 31, 2019

Conversation

@ztplz
Copy link
Contributor

@ztplz ztplz commented Mar 31, 2019

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

馃懟 What's the background?

  1. Describe the source of requirement, like related issue link.
    #15055 (comment)

  2. Describe the problem and the scenario.

馃挕 Solution

  1. How to fix the problem, and list final API implementation and usage sample if that is an new feature.

  2. GIF or snapshot should be provided if includes UI/interactive modification.

馃摑 Changelog description

Describe changes from userside, and list all potential break changes or other risks.

  1. English description

  2. Chinese description (optional)

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed
@ztplz ztplz requested review from afc163 and zombieJ Mar 31, 2019
@ztplz
Copy link
Contributor Author

@ztplz ztplz commented Mar 31, 2019

@zombieJ string?

@zombieJ
Copy link
Member

@zombieJ zombieJ commented Mar 31, 2019

鍥犱负鍐呴儴鏄 any锛岃繖閲岀敤 Node 鍚

@netlify
Copy link

@netlify netlify bot commented Mar 31, 2019

Deploy preview for ant-design ready!

Built with commit 3ca1ac9

https://deploy-preview-15765--ant-design.netlify.com

@codecov
Copy link

@codecov codecov bot commented Mar 31, 2019

Codecov Report

Merging #15765 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #15765   +/-   ##
=======================================
  Coverage   95.03%   95.03%           
=======================================
  Files         250      250           
  Lines        6640     6640           
  Branches     1907     1942   +35     
=======================================
  Hits         6310     6310           
  Misses        329      329           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update b56d651...ebcfeb1. Read the comment docs.

@codecov
Copy link

@codecov codecov bot commented Mar 31, 2019

Codecov Report

Merging #15765 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #15765   +/-   ##
=======================================
  Coverage   95.03%   95.03%           
=======================================
  Files         250      250           
  Lines        6640     6640           
  Branches     1907     1907           
=======================================
  Hits         6310     6310           
  Misses        329      329           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update b56d651...3ca1ac9. Read the comment docs.

@zombieJ zombieJ merged commit 298a86f into ant-design:master Mar 31, 2019
28 checks passed
@ztplz ztplz deleted the sep branch Mar 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants