Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix col element missing relative style #15766

Merged
merged 1 commit into from Mar 31, 2019
Merged

Fix col element missing relative style #15766

merged 1 commit into from Mar 31, 2019

Conversation

@afc163
Copy link
Member

@afc163 afc163 commented Mar 31, 2019

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

馃懟 What's the background?

close #15626

馃挕 Solution

Adding ant-col className to every column elements.

馃摑 Changelog description

Describe changes from userside, and list all potential break changes or other risks.

  1. English description
  • 馃悰 Fix col element missing relative style. #15626
  1. Chinese description (optional)

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed
@netlify
Copy link

@netlify netlify bot commented Mar 31, 2019

Deploy preview for ant-design ready!

Built with commit 95bd4d6

https://deploy-preview-15766--ant-design.netlify.com

@codecov
Copy link

@codecov codecov bot commented Mar 31, 2019

Codecov Report

Merging #15766 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #15766   +/-   ##
=======================================
  Coverage   95.03%   95.03%           
=======================================
  Files         250      250           
  Lines        6640     6640           
  Branches     1940     1907   -33     
=======================================
  Hits         6310     6310           
  Misses        329      329           
  Partials        1        1
Impacted Files Coverage 螖
components/grid/col.tsx 100% <酶> (酶) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update f55ccfe...95bd4d6. Read the comment docs.

@afc163 afc163 merged commit 2cec053 into master Mar 31, 2019
30 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix-missing-col-className branch Mar 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

1 participant