Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix Table filter display issue when use non-string type #15817

Merged
merged 2 commits into from Apr 2, 2019

Conversation

Projects
None yet
2 participants
@zombieJ
Copy link
Member

commented Apr 2, 2019

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

馃懟 What's the background?

fix: #15593

馃挕 Solution

Internal use String for selectedKeys tracking, we should convert back when confirmed.

馃摑 Changelog

Fix Table filter display issue when use non-string type.

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed
@netlify

This comment has been minimized.

Copy link

commented Apr 2, 2019

Deploy preview for ant-design ready!

Built with commit 9870ba1

https://deploy-preview-15817--ant-design.netlify.com

An enterprise-class UI design language and React-based implementation with a set of high-quality React components, one of best React UI library for enterprises
@codecov

This comment has been minimized.

Copy link

commented Apr 2, 2019

Codecov Report

Merging #15817 into master will decrease coverage by 0.57%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15817      +/-   ##
==========================================
- Coverage   95.06%   94.48%   -0.58%     
==========================================
  Files         251      251              
  Lines        6663     6657       -6     
  Branches     1913     1945      +32     
==========================================
- Hits         6334     6290      -44     
- Misses        328      366      +38     
  Partials        1        1
Impacted Files Coverage 螖
components/table/filterDropdown.tsx 79.66% <100%> (-15.22%) 猬囷笍
components/table/Table.tsx 89.46% <0%> (-3.52%) 猬囷笍
components/badge/ScrollNumber.tsx 97.05% <0%> (-1.61%) 猬囷笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 6b2d72e...9870ba1. Read the comment docs.

@zombieJ zombieJ requested review from afc163 and ztplz Apr 2, 2019

@zombieJ zombieJ merged commit 87a9c42 into master Apr 2, 2019

29 of 31 checks passed

Header rules No header rules processed
Details
Pages changed 12 new files uploaded
Details
CodeFactor No issues found.
Details
DEP All dependencies are resolved
LGTM analysis: JavaScript No new or fixed alerts
Details
License Compliance All checks passed.
Details
Mixed content No mixed content detected
Details
Redirect rules 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize No prior size to compare - 798.4聽KB
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codebeat no reportable quality changes
Details
codecov/patch 100% of diff hit (target 95.06%)
Details
codecov/project Absolute coverage decreased by -0.57% but relative coverage increased by +4.93% compared to 6b2d72e
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@delete-merged-branch delete-merged-branch bot deleted the table-filter branch Apr 2, 2019

@afc163

This comment has been minimized.

Copy link
Member

commented Apr 2, 2019

馃憤

@@ -361,7 +361,7 @@ describe('Table.filter', () => {
jest.useRealTimers();
});

describe('should support value types', () => {
describe.only('should support value types', () => {

This comment has been minimized.

Copy link
@afc163

afc163 Apr 2, 2019

Member

.only

@weekly-digest weekly-digest bot referenced this pull request Apr 14, 2019

Closed

Weekly Digest (7 April, 2019 - 14 April, 2019) #16069

1 of 9 tasks complete

@zombieJ zombieJ restored the table-filter branch Jun 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.