Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(TimePicker): prop locale should works #15837

Merged
merged 1 commit into from Apr 4, 2019
Merged

Conversation

@dengfuping
Copy link
Contributor

@dengfuping dengfuping commented Apr 3, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

👻 What's the background?

💡 Solution

📝 Changelog

  • English Changelog:

  • 🐞 Fix that prop locale doesn't work for TimePicker. #15813

  • Chinese Changelog (optional):

  • 🐞 修复 TimePicker 组件的 locale 属性不生效的问题。#15813

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed
@codecov
Copy link

@codecov codecov bot commented Apr 3, 2019

Codecov Report

Merging #15837 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15837      +/-   ##
==========================================
+ Coverage   95.06%   95.06%   +<.01%     
==========================================
  Files         251      251              
  Lines        6664     6667       +3     
  Branches     1947     1935      -12     
==========================================
+ Hits         6335     6338       +3     
  Misses        328      328              
  Partials        1        1
Impacted Files Coverage Δ
components/time-picker/index.tsx 98.64% <100%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1a1cda...984ae2a. Read the comment docs.

@netlify
Copy link

@netlify netlify bot commented Apr 3, 2019

Deploy preview for ant-design ready!

Built with commit 984ae2a

https://deploy-preview-15837--ant-design.netlify.com

An enterprise-class UI design language and React-based implementation with a set of high-quality React components, one of best React UI library for enterprises

afc163
afc163 approved these changes Apr 3, 2019
@dengfuping dengfuping merged commit 3c75c4f into master Apr 4, 2019
32 checks passed
32 checks passed
@netlify[bot]
Header rules No header rules processed
Details
@netlify[bot]
Pages changed 12 new files uploaded
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
CodeFactor No issues found.
Details
@dep[bot]
DEP All dependencies are resolved
LGTM analysis: JavaScript No new or fixed alerts
Details
License Compliance All checks passed.
Details
@netlify[bot]
Mixed content No mixed content detected
Details
@netlify[bot]
Redirect rules 18 redirect rules processed
Details
@semantic-pull-requests[bot]
Semantic Pull Request ready to be merged or rebased
Details
@wip[bot]
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
@buildsize[bot]
buildsize No prior size to compare - 800.16 KB
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codebeat 1 issue resolved and 1 introduced
Details
@codecov[bot]
codecov/patch 100% of diff hit (target 95.06%)
Details
@codecov[bot]
codecov/project 95.06% (+<.01%) compared to e1a1cda
Details
@netlify[bot]
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected
@delete-merged-branch delete-merged-branch bot deleted the fix-timepicker-locale branch Apr 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants