Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(Empty): create simple style Empty in a default way #15841

Merged
merged 2 commits into from Apr 4, 2019

Conversation

@afc163
Copy link
Member

@afc163 afc163 commented Apr 3, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

👻 What's the background?

Now we use <Empty image={Empty.PRESENTED_IMAGE_SIMPLE} />, it looks like:

image

https://codesandbox.io/s/4rw1n098w4

We should make it's look same as:

image

💡 Solution

Add proper className when image is equals to Empty.PRESENTED_IMAGE_SIMPLE.

📝 Changelog

  • English Changelog: 💄 Optimize default UI of <Empty image={Empty.PRESENTED_IMAGE_SIMPLE} />.
  • Chinese Changelog (optional): 💄 优化 <Empty image={Empty.PRESENTED_IMAGE_SIMPLE} /> 的默认样式。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed
@@ -32,7 +32,7 @@

&-empty-text {
padding: @list-empty-text-padding;
color: @text-color-secondary;
color: @disabled-color;
Copy link
Member Author

@afc163 afc163 Apr 3, 2019

Unified the text color of Empty description too.

@afc163 afc163 force-pushed the improve-empty-built-style branch from 0ca875c to bc73772 Apr 3, 2019
@netlify
Copy link

@netlify netlify bot commented Apr 3, 2019

Deploy preview for ant-design ready!

Built with commit 5ee4efb

https://deploy-preview-15841--ant-design.netlify.com

An enterprise-class UI design language and React-based implementation with a set of high-quality React components, one of best React UI library for enterprises

@netlify
Copy link

@netlify netlify bot commented Apr 3, 2019

Deploy preview for ant-design ready!

Built with commit bc73772

https://deploy-preview-15841--ant-design.netlify.com

An enterprise-class UI design language and React-based implementation with a set of high-quality React components, one of best React UI library for enterprises

@codecov
Copy link

@codecov codecov bot commented Apr 3, 2019

Codecov Report

Merging #15841 into master will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15841      +/-   ##
==========================================
+ Coverage      95%   95.06%   +0.06%     
==========================================
  Files         251      251              
  Lines        6664     6664              
  Branches     1949     1913      -36     
==========================================
+ Hits         6331     6335       +4     
+ Misses        332      328       -4     
  Partials        1        1
Impacted Files Coverage Δ
components/empty/index.tsx 94.73% <ø> (ø) ⬆️
components/config-provider/renderEmpty.tsx 86.66% <100%> (ø) ⬆️
components/form/FormItem.tsx 98.85% <0%> (+2.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc8db23...bc73772. Read the comment docs.

@afc163 afc163 merged commit 5e9f9f8 into master Apr 4, 2019
31 checks passed
@delete-merged-branch delete-merged-branch bot deleted the improve-empty-built-style branch Apr 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant