Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Steps): :bug: style broken when progressDot and size="small" #15856

Merged
merged 1 commit into from Apr 4, 2019

Conversation

Projects
None yet
1 participant
@afc163
Copy link
Member

commented Apr 4, 2019

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

馃懟 What's the background?

close #15566
close #15849

image

馃挕 Solution

馃摑 Changelog

  • English Changelog: Fixed Steps style broken when progressDot and size="small". #15566
  • Chinese Changelog (optional):

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed
@codecov

This comment has been minimized.

Copy link

commented Apr 4, 2019

Codecov Report

Merging #15856 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #15856   +/-   ##
=======================================
  Coverage   95.06%   95.06%           
=======================================
  Files         251      251           
  Lines        6664     6664           
  Branches     1913     1935   +22     
=======================================
  Hits         6335     6335           
  Misses        328      328           
  Partials        1        1
Impacted Files Coverage 螖
components/empty/index.tsx 94.73% <0%> (酶) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 5e9f9f8...6625fb5. Read the comment docs.

@netlify

This comment has been minimized.

Copy link

commented Apr 4, 2019

Deploy preview for ant-design ready!

Built with commit 6625fb5

https://deploy-preview-15856--ant-design.netlify.com

An enterprise-class UI design language and React-based implementation with a set of high-quality React components, one of best React UI library for enterprises

@afc163 afc163 merged commit d8e9b0c into master Apr 4, 2019

29 of 31 checks passed

Header rules No header rules processed
Details
Pages changed 12 new files uploaded
Details
CodeFactor No issues found.
Details
DEP All dependencies are resolved
LGTM analysis: JavaScript No code changes detected
Details
License Compliance All checks passed.
Details
Mixed content No mixed content detected
Details
Redirect rules 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize No prior size to compare - 800.16聽KB
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codebeat no reportable quality changes
Details
codecov/patch Coverage not affected when comparing 5e9f9f8...6625fb5
Details
codecov/project 95.06% remains the same compared to 5e9f9f8
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@delete-merged-branch delete-merged-branch bot deleted the fix-steps-style branch Apr 4, 2019

@weekly-digest weekly-digest bot referenced this pull request Apr 14, 2019

Closed

Weekly Digest (7 April, 2019 - 14 April, 2019) #16069

1 of 9 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.