Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Icon enable search #15867

Merged
merged 1 commit into from Apr 6, 2019
Merged

docs: Icon enable search #15867

merged 1 commit into from Apr 6, 2019

Conversation

@DiamondYuan
Copy link
Contributor

@DiamondYuan DiamondYuan commented Apr 4, 2019

🤔 这个变动的性质是?

  • 新特性提交
  • 日常 bug 修复
  • 站点、文档改进
  • 组件样式改进
  • TypeScript 定义更新
  • 重构
  • 代码风格优化
  • 分支合并
  • 其他改动(是关于什么的改动?)

👻 需求背景

#15854

@buildsize
Copy link

@buildsize buildsize bot commented Apr 4, 2019

File name Previous Size New Size Change
package-lock.json 800.16 KB 804.7 KB 4.55 KB (1%)

Loading

@netlify
Copy link

@netlify netlify bot commented Apr 4, 2019

Deploy preview for ant-design ready!

Built with commit 79ecd32

https://deploy-preview-15867--ant-design.netlify.com

Loading

@afc163
Copy link
Member

@afc163 afc163 commented Apr 4, 2019

This pull request introduces 1 alert when merging 1b57b7e into 3c75c4f - view on LGTM.com

new alerts:

  • 1 for Potentially inconsistent state update

Comment posted by LGTM.com

Loading

@afc163
Copy link
Member

@afc163 afc163 commented Apr 4, 2019

Search 可以填满 Radio 以外的一整行。两个 size 都改成大的吧。

Loading

site/theme/template/IconDisplay/index.tsx Outdated Show resolved Hide resolved
Loading
@codecov
Copy link

@codecov codecov bot commented Apr 4, 2019

Codecov Report

Merging #15867 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15867      +/-   ##
==========================================
- Coverage    95.1%   95.05%   -0.05%     
==========================================
  Files         251      251              
  Lines        6675     6675              
  Branches     1913     1947      +34     
==========================================
- Hits         6348     6345       -3     
- Misses        326      329       +3     
  Partials        1        1
Impacted Files Coverage Δ
components/_util/wave.tsx 85.57% <0%> (-2.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7d2dd7...79ecd32. Read the comment docs.

Loading

@DiamondYuan DiamondYuan requested a review from afc163 Apr 4, 2019
@afc163
Copy link
Member

@afc163 afc163 commented Apr 4, 2019

ci 挂了

Loading

@afc163 afc163 changed the title feat: Icon enable search docs: Icon enable search Apr 6, 2019
@afc163 afc163 merged commit 3d05976 into master Apr 6, 2019
32 checks passed
Loading
@delete-merged-branch delete-merged-branch bot deleted the site-search branch Apr 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants