Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix lots of missing icons #15874

Merged
merged 4 commits into from May 7, 2019

Conversation

Projects
None yet
2 participants
@afc163
Copy link
Member

commented Apr 4, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

👻 What's the background?

close ant-design/ant-design-icons#26
close #15850

Depends on ant-design/ant-design-icons#53

💡 Solution

不完全统计,修复了以下丢失的图标:

📝 Changelog

  • English Changelog:
  • Chinese Changelog (optional):

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed
@netlify

This comment has been minimized.

Copy link

commented Apr 4, 2019

Deploy preview for ant-design ready!

Built with commit 4a6723c

https://deploy-preview-15874--ant-design.netlify.com

@afc163 afc163 force-pushed the fix-missing-icons branch from 85b1682 to f41b3e4 Apr 4, 2019

@codecov

This comment has been minimized.

Copy link

commented Apr 4, 2019

Codecov Report

Merging #15874 into feature will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           feature   #15874      +/-   ##
===========================================
- Coverage    95.69%   95.65%   -0.05%     
===========================================
  Files          258      258              
  Lines         7109     7109              
  Branches      1970     1994      +24     
===========================================
- Hits          6803     6800       -3     
- Misses         304      307       +3     
  Partials         2        2
Impacted Files Coverage Δ
components/_util/wave.tsx 85.84% <0%> (-2.84%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 772638e...4a6723c. Read the comment docs.

@afc163 afc163 force-pushed the fix-missing-icons branch from f41b3e4 to 4b09eac Apr 4, 2019

@afc163 afc163 changed the title Fix lots of missing icons fix: Fix lots of missing icons Apr 4, 2019

@afc163

This comment has been minimized.

Copy link
Member Author

commented May 6, 2019

@zombieJ

This comment has been minimized.

Copy link
Member

commented May 7, 2019

antd icons 升级了 2.0,我来移到 feature branch

zombieJ added some commits May 7, 2019

@zombieJ zombieJ changed the base branch from master to feature May 7, 2019

@buildsize

This comment has been minimized.

Copy link

commented May 7, 2019

File name Previous Size New Size Change
package-lock.json 818.65 KB 819.41 KB 779 bytes (0%)

@zombieJ zombieJ marked this pull request as ready for review May 7, 2019

@zombieJ

zombieJ approved these changes May 7, 2019

@zombieJ zombieJ merged commit e184045 into feature May 7, 2019

27 of 29 checks passed

Header rules No header rules processed
Details
Pages changed 211 new files uploaded
Details
DEP All dependencies are resolved
LGTM analysis: JavaScript No new or fixed alerts
Details
License Compliance All checks passed.
Details
Mixed content No mixed content detected
Details
Redirect rules 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize Significant change of package-lock.json up by 779 bytes (0.09%)
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 772638e...4a6723c
Details
codecov/project 95.65% (-0.05%) compared to 772638e
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No new issues
Details

@delete-merged-branch delete-merged-branch bot deleted the fix-missing-icons branch May 7, 2019

@zombieJ

This comment has been minimized.

Copy link
Member

commented May 7, 2019

Long time PR makes many conflict.
Let's handle ant-design/ant-design-icons#55 in another one.

@zombieJ zombieJ referenced this pull request May 8, 2019

Merged

reload-time => history #53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.