Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add warning when DatePicker using invalidate time #15920

Merged
merged 1 commit into from Apr 8, 2019

Conversation

@zombieJ
Copy link
Member

@zombieJ zombieJ commented Apr 8, 2019

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

馃懟 What's the background?

close #15917

馃挕 Solution

Add additional check of defaultValue & value

馃摑 Changelog

Add warning when DatePicker using invalidate time.

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed
@netlify
Copy link

@netlify netlify bot commented Apr 8, 2019

Deploy preview for ant-design ready!

Built with commit 72bbcfb

https://deploy-preview-15920--ant-design.netlify.com

An enterprise-class UI design language and React-based implementation with a set of high-quality React components, one of best React UI library for enterprises

@codecov
Copy link

@codecov codecov bot commented Apr 8, 2019

Codecov Report

Merging #15920 into master will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15920      +/-   ##
==========================================
+ Coverage   95.06%   95.12%   +0.06%     
==========================================
  Files         251      251              
  Lines        6681     6692      +11     
  Branches     1951     1954       +3     
==========================================
+ Hits         6351     6366      +15     
+ Misses        329      325       -4     
  Partials        1        1
Impacted Files Coverage 螖
components/date-picker/wrapPicker.tsx 100% <100%> (酶) 猬嗭笍
components/form/FormItem.tsx 98.85% <0%> (+2.28%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 3714338...72bbcfb. Read the comment docs.

1 similar comment
@codecov
Copy link

@codecov codecov bot commented Apr 8, 2019

Codecov Report

Merging #15920 into master will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15920      +/-   ##
==========================================
+ Coverage   95.06%   95.12%   +0.06%     
==========================================
  Files         251      251              
  Lines        6681     6692      +11     
  Branches     1951     1954       +3     
==========================================
+ Hits         6351     6366      +15     
+ Misses        329      325       -4     
  Partials        1        1
Impacted Files Coverage 螖
components/date-picker/wrapPicker.tsx 100% <100%> (酶) 猬嗭笍
components/form/FormItem.tsx 98.85% <0%> (+2.28%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 3714338...72bbcfb. Read the comment docs.

@zombieJ zombieJ merged commit 100ebc9 into master Apr 8, 2019
32 checks passed
@delete-merged-branch delete-merged-branch bot deleted the warning-invalidate-time branch Apr 8, 2019
import TimePickerPanel from 'rc-time-picker/lib/Panel';
import classNames from 'classnames';
import * as moment from 'moment';
Copy link
Contributor

@nikogu nikogu Apr 16, 2019

why import * as moment from 'moment' ? This will return a Module銆

image

Copy link
Member Author

@zombieJ zombieJ Apr 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants