Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: TreeSelect support `showSearch` in multiple mode #15933

Merged
merged 8 commits into from Apr 8, 2019

Conversation

Projects
None yet
2 participants
@zombieJ
Copy link
Member

commented Apr 8, 2019

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

馃懟 What's the background?

close #15921

馃挕 Solution

Update rc-tree-select to support that.

馃摑 Changelog

TreeSelect support showSearch in multiple mode.

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

zombieJ added some commits Apr 3, 2019

Merge pull request #15829 from ant-design/merge-master
feat: Feature merge master
@netlify

This comment has been minimized.

Copy link

commented Apr 8, 2019

Deploy preview for ant-design ready!

Built with commit 2071fdd

https://deploy-preview-15933--ant-design.netlify.com

@buildsize

This comment has been minimized.

Copy link

commented Apr 8, 2019

File name Previous Size New Size Change
package-lock.json 802.26聽KB 804.38聽KB 2.12聽KB (0%)
@zombieJ

This comment has been minimized.

Copy link
Member Author

commented Apr 8, 2019

antd 涓粯璁 showSearchfalse銆傛敮鎸佸悗锛孴reeSelect 榛樿鏄病鏈 Search 鐨勩傝繖鐐规劅瑙夎璋冩暣涓涓嬨傛枃妗i噷鎻忚堪涔熻鏀规垚锛

`false` when single | `true` when multiple
@codecov

This comment has been minimized.

Copy link

commented Apr 8, 2019

Codecov Report

Merging #15933 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15933      +/-   ##
==========================================
+ Coverage   95.12%   95.12%   +<.01%     
==========================================
  Files         251      251              
  Lines        6688     6691       +3     
  Branches     1952     1920      -32     
==========================================
+ Hits         6362     6365       +3     
  Misses        325      325              
  Partials        1        1
Impacted Files Coverage 螖
components/tree-select/index.tsx 94.87% <100%> (+0.42%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 9190245...2071fdd. Read the comment docs.

zombieJ added some commits Apr 8, 2019

@zombieJ zombieJ merged commit fa47d9c into master Apr 8, 2019

28 of 30 checks passed

Header rules No header rules processed
Details
Pages changed 12 new files uploaded
Details
CodeFactor No issues found.
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
License Compliance All checks passed.
Details
Mixed content No mixed content detected
Details
Redirect rules 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize Significant change of package-lock.json up by 2.12聽KB (0.26%)
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codebeat no reportable quality changes
Details
codecov/patch 100% of diff hit (target 95.12%)
Details
codecov/project 95.12% (+<.01%) compared to 9190245
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No new issues
Details

@delete-merged-branch delete-merged-branch bot deleted the tree-select-showSearch branch Apr 8, 2019

@zombieJ

This comment has been minimized.

Copy link
Member Author

commented Apr 8, 2019

鍙戦敊鍒 master 浜嗭紝revert 鎺夈

zombieJ added a commit that referenced this pull request Apr 8, 2019

zombieJ added a commit that referenced this pull request Apr 8, 2019

zombieJ added a commit that referenced this pull request Apr 8, 2019

feat: TreeSelect support `showSearch` in multiple mode (#15933)
* update rc-tree-select

* typo

* update desc & snapshot

* update desc & snapshot

* check default showSearch

chenshuai2144 added a commit that referenced this pull request Apr 8, 2019

Merge pull request #15947 from ant-design/tree-select-showSearch
feat: TreeSelect support `showSearch` in multiple mode (#15933)

chenshuai2144 added a commit that referenced this pull request May 6, 2019

meger feature to master (#16421)
* use ul in list

* update snapshot

* update comment

* feat: TreeSelect support `showSearch` in multiple mode (#15933)

* update rc-tree-select

* typo

* update desc & snapshot

* update desc & snapshot

* check default showSearch

* feat: table customizing variable (#15971)

* feat: added table selected row color variable

* fix: @table-selected-row-color default is inherit

* feat: Upload support customize previewFile (#15984)

* support preview file

* use promise

* dealy load

* use canvas of render

* use domHook of test

* update demo

* add snapshot

* update types

* update testcase

* feat: form customizing variables (#15954)

* fix: added styling form input background-color

* feat: added '@form-warning-input-bg' variable

* feat: added '@form-error-input-bg' variable

* use li wrap with comment

* feat: Support append theme less file with less-variable (#16118)

* add override

* add override support

* update doc

* feat: dropdown support set right icon

* docs: update doc of dropdown component

* style: format dropdown-button.md

* test: update updateSnapshot

* style: format dropdown-button.md

* test: update updateSnapshot

* test: update updateSnapshot

* style: change style of dropdown-button demo

* fix: fix document table order

* feat: Support SkeletonAvatarProps.size accept number (#16078) (#16128)

* chore:update style of demo

* feat: Notification functions accept top, bottom and getContainer as arguments

* drawer: add afterVisibleChange

* rm onVisibleChange

* update

* feat: 馃嚟馃嚪 hr_HR locale (#16258)

* Added Croatian locale

* fixed lint error

*  Add test cases for hr_HR

* 馃摑 update i18n documentation

* feat:  add `htmlFor` in Form.Item (#16278)

* add htmlFor in Form.Item

* update doc

* feat: Button support `link` type (#16289)

close #15892

* feat: Add Timeline.Item.position (#16148) (#16193)

* fix: Timeline.pendingDot interface documentation there is a small problem (#16177)

* feat: Add Timeline.Item.position (#16148)

* doc: add version infomation for Timeline.Item.position

* refactor: Update Tree & TreeSelect deps (#16330)

* use CSSMotion

* update snapshot

* feat: Collapse support `expandIconPosition` (#16365)

* update doc

* support expandIconPosition

* update snapshot

* feat: Breadcrumb  support DropDown (#16315)

* breadcrumbs support drop down menu

* update doc

* add require less

* fix test

* fix md doc

* less code

* fix  style warning

* update snap

* add children render test

* feat: TreeNode support checkable

* feat: add optional to support top and left slick dots (#16186) (#16225)

* add optional to support top and left slick dots

* update carousel snapshot

* Update doc, add placement demo

* update carousel placement demo snapshots

* rename dots placement to position

* update vertical as deprecated

* rename dotsPosition to dotPosition

* refine code

* add warning testcase for vertical

* remove unused warning

* update expression

* Additional test case for dotPosition

* refactor: Upgrade `rc-tree-select` to support pure React motion (#16402)

* upgrade `rc-tree-select`

* update snapshot

* 3.17.0 changelog

* fix warning

* fix review warning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.