Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Menu defaultOpenKeys not work as expect #15970

Merged
merged 2 commits into from Apr 9, 2019
Merged

fix: Menu defaultOpenKeys not work as expect #15970

merged 2 commits into from Apr 9, 2019

Conversation

@zombieJ
Copy link
Member

@zombieJ zombieJ commented Apr 9, 2019

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

馃懟 What's the background?

fix #15966

馃挕 Solution

Remove animation at first render frame.

馃摑 Changelog

Fix Menu defaultOpenKeys not work as expect.

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed
@zombieJ
Copy link
Member Author

@zombieJ zombieJ commented Apr 9, 2019

It's hard to write test since align logic works but not as expect.

@zombieJ zombieJ requested a review from afc163 Apr 9, 2019
@netlify
Copy link

@netlify netlify bot commented Apr 9, 2019

Deploy preview for ant-design ready!

Built with commit 07e7a89

https://deploy-preview-15970--ant-design.netlify.com

@codecov
Copy link

@codecov codecov bot commented Apr 9, 2019

Codecov Report

Merging #15970 into master will decrease coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #15970     +/-   ##
=========================================
- Coverage    95.2%    95.1%   -0.1%     
=========================================
  Files         251      251             
  Lines        6710     6703      -7     
  Branches     1955     1944     -11     
=========================================
- Hits         6388     6375     -13     
- Misses        321      327      +6     
  Partials        1        1
Impacted Files Coverage 螖
components/menu/index.tsx 97.43% <100%> (+0.13%) 猬嗭笍
components/_util/raf.ts 100% <100%> (酶) 猬嗭笍
components/_util/openAnimation.tsx 67.85% <0%> (-7.15%) 猬囷笍
components/_util/wave.tsx 85.57% <0%> (-2.89%) 猬囷笍
components/tree/util.ts 94.28% <0%> (-1.27%) 猬囷笍
components/tree/DirectoryTree.tsx 96.51% <0%> (-1.27%) 猬囷笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 645557f...07e7a89. Read the comment docs.

@zombieJ zombieJ merged commit bef491e into master Apr 9, 2019
29 of 30 checks passed
@delete-merged-branch delete-merged-branch bot deleted the menu-defaultOpen branch Apr 9, 2019
DiamondYuan added a commit that referenced this issue Apr 12, 2019
* Remove animation on first render

* update test cas
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

1 participant