Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Upload support customize previewFile #15984

Merged
merged 9 commits into from Apr 11, 2019

Conversation

Projects
None yet
3 participants
@zombieJ
Copy link
Member

commented Apr 10, 2019

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

馃懟 What's the background?

close #15885
Laggy when upload large image file

馃挕 Solution

Provides previewFile to customize preview logic.

馃摑 Changelog

Upload support customize previewFile

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed
  • Test ready

View rendered components/upload/demo/preview-file.md
View rendered components/upload/index.en-US.md
View rendered components/upload/index.zh-CN.md

@pr-triage pr-triage bot added the PR: unreviewed label Apr 10, 2019

@zombieJ zombieJ requested review from afc163, yesmeck, ztplz and DiamondYuan Apr 10, 2019

@netlify

This comment has been minimized.

Copy link

commented Apr 10, 2019

Deploy preview for ant-design ready!

Built with commit bb46e57

https://deploy-preview-15984--ant-design.netlify.com

@todo

This comment was marked as outdated.

Copy link

commented Apr 10, 2019

Optimize this with `requestIdleCallback` after we don't support old browser.

// TODO: Optimize this with `requestIdleCallback` after we don't support old browser.
let id: number;
function step() {
const subStr = binary.substr(offset, BASE64_CHUNK_SIZE);
baseStr += btoa(subStr);
offset += BASE64_CHUNK_SIZE;


This comment was generated by todo based on a TODO comment in 9a83bbe in #15984. cc @ant-design.

zombieJ added some commits Apr 10, 2019

@zombieJ

This comment has been minimized.

Copy link
Member Author

commented Apr 10, 2019

鎶戒簡 spyElementPrototype / spyElementPrototypes 鐢ㄤ簬鏀寔鍘熺敓 HTMLElement 鐨 prototype spy:

// property type
const imageSpy = spyElementPrototype(Image, 'src', {
  set() {},
});

// function type
const canvasSpy = spyElementPrototype(HTMLCanvasElement,  'toDataURL', () => null);

// Restore
imageSpy.mockRestore();
canvasSpy.mockRestore();

鍚堝畬鍚庯紝鎶婂叾浠栨墜宸ョ殑涔熸崲鎴愬皝瑁呯殑銆

zombieJ added some commits Apr 10, 2019

@codecov

This comment has been minimized.

Copy link

commented Apr 10, 2019

Codecov Report

Merging #15984 into feature will decrease coverage by 0.08%.
The diff coverage is 98.24%.

Impacted file tree graph

@@             Coverage Diff             @@
##           feature   #15984      +/-   ##
===========================================
- Coverage    95.17%   95.08%   -0.09%     
===========================================
  Files          251      251              
  Lines         6691     6716      +25     
  Branches      1956     1957       +1     
===========================================
+ Hits          6368     6386      +18     
- Misses         322      329       +7     
  Partials         1        1
Impacted Files Coverage 螖
components/upload/Upload.tsx 94.26% <100%> (酶) 猬嗭笍
components/upload/UploadList.tsx 96.47% <100%> (+0.14%) 猬嗭笍
components/upload/utils.tsx 98.66% <97.95%> (-1.34%) 猬囷笍
components/_util/wave.tsx 85.57% <0%> (-2.89%) 猬囷笍
components/form/FormItem.tsx 96.49% <0%> (-2.34%) 猬囷笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 574313d...bb46e57. Read the comment docs.

@zombieJ zombieJ marked this pull request as ready for review Apr 10, 2019

@zombieJ

This comment has been minimized.

Copy link
Member Author

commented Apr 11, 2019

Done. Please check.

@afc163

afc163 approved these changes Apr 11, 2019

@zombieJ zombieJ merged commit c4283eb into feature Apr 11, 2019

28 of 30 checks passed

Header rules No header rules processed
Details
Pages changed 12 new files uploaded
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
DEP All dependencies are resolved
LGTM analysis: JavaScript No new or fixed alerts
Details
License Compliance All checks passed.
Details
Mixed content No mixed content detected
Details
Redirect rules 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
buildsize No significant change
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codebeat Target branch is not tracked
Details
codecov/patch 98.24% of diff hit (target 95.17%)
Details
codecov/project Absolute coverage decreased by -0.08% but relative coverage increased by +3.07% compared to 574313d
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@delete-merged-branch delete-merged-branch bot deleted the upload-preview-file branch Apr 11, 2019

DiamondYuan added a commit that referenced this pull request Apr 12, 2019

feat: Upload support customize previewFile (#15984)
* support preview file

* use promise

* dealy load

* use canvas of render

* use domHook of test

* update demo

* add snapshot

* update types

* update testcase

chenshuai2144 added a commit that referenced this pull request May 6, 2019

meger feature to master (#16421)
* use ul in list

* update snapshot

* update comment

* feat: TreeSelect support `showSearch` in multiple mode (#15933)

* update rc-tree-select

* typo

* update desc & snapshot

* update desc & snapshot

* check default showSearch

* feat: table customizing variable (#15971)

* feat: added table selected row color variable

* fix: @table-selected-row-color default is inherit

* feat: Upload support customize previewFile (#15984)

* support preview file

* use promise

* dealy load

* use canvas of render

* use domHook of test

* update demo

* add snapshot

* update types

* update testcase

* feat: form customizing variables (#15954)

* fix: added styling form input background-color

* feat: added '@form-warning-input-bg' variable

* feat: added '@form-error-input-bg' variable

* use li wrap with comment

* feat: Support append theme less file with less-variable (#16118)

* add override

* add override support

* update doc

* feat: dropdown support set right icon

* docs: update doc of dropdown component

* style: format dropdown-button.md

* test: update updateSnapshot

* style: format dropdown-button.md

* test: update updateSnapshot

* test: update updateSnapshot

* style: change style of dropdown-button demo

* fix: fix document table order

* feat: Support SkeletonAvatarProps.size accept number (#16078) (#16128)

* chore:update style of demo

* feat: Notification functions accept top, bottom and getContainer as arguments

* drawer: add afterVisibleChange

* rm onVisibleChange

* update

* feat: 馃嚟馃嚪 hr_HR locale (#16258)

* Added Croatian locale

* fixed lint error

*  Add test cases for hr_HR

* 馃摑 update i18n documentation

* feat:  add `htmlFor` in Form.Item (#16278)

* add htmlFor in Form.Item

* update doc

* feat: Button support `link` type (#16289)

close #15892

* feat: Add Timeline.Item.position (#16148) (#16193)

* fix: Timeline.pendingDot interface documentation there is a small problem (#16177)

* feat: Add Timeline.Item.position (#16148)

* doc: add version infomation for Timeline.Item.position

* refactor: Update Tree & TreeSelect deps (#16330)

* use CSSMotion

* update snapshot

* feat: Collapse support `expandIconPosition` (#16365)

* update doc

* support expandIconPosition

* update snapshot

* feat: Breadcrumb  support DropDown (#16315)

* breadcrumbs support drop down menu

* update doc

* add require less

* fix test

* fix md doc

* less code

* fix  style warning

* update snap

* add children render test

* feat: TreeNode support checkable

* feat: add optional to support top and left slick dots (#16186) (#16225)

* add optional to support top and left slick dots

* update carousel snapshot

* Update doc, add placement demo

* update carousel placement demo snapshots

* rename dots placement to position

* update vertical as deprecated

* rename dotsPosition to dotPosition

* refine code

* add warning testcase for vertical

* remove unused warning

* update expression

* Additional test case for dotPosition

* refactor: Upgrade `rc-tree-select` to support pure React motion (#16402)

* upgrade `rc-tree-select`

* update snapshot

* 3.17.0 changelog

* fix warning

* fix review warning
@wuxingjiang007

This comment has been minimized.

Copy link

commented May 9, 2019

鐢ㄤ笉浜嗗晩锛屼篃娌℃姤閿, tslint鎻愮ず锛歍his may be converted to an async function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.