Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Dropdown support set right icon #15996

Merged
merged 10 commits into from Apr 19, 2019

Conversation

Projects
None yet
3 participants
@DiamondYuan
Copy link
Collaborator

commented Apr 10, 2019

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

馃懟 What's the background?

close #15989

馃挕 Solution

馃摑 Changelog

  • English Changelog:
  • Chinese Changelog (optional):

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/dropdown/demo/dropdown-button.md
View rendered components/dropdown/demo/sub-menu.md
View rendered components/dropdown/index.en-US.md
View rendered components/dropdown/index.zh-CN.md
View rendered components/tree-select/index.en-US.md
View rendered components/tree-select/index.zh-CN.md

@pr-triage pr-triage bot added the PR: unreviewed label Apr 10, 2019

@DiamondYuan DiamondYuan changed the base branch from master to feature Apr 10, 2019

@DiamondYuan DiamondYuan requested a review from afc163 Apr 10, 2019

@DiamondYuan

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 10, 2019

demo 鏈 snapshots 娴嬭瘯浜嗐

@netlify

This comment has been minimized.

Copy link

commented Apr 10, 2019

Deploy preview for ant-design ready!

Built with commit f676cfa

https://deploy-preview-15996--ant-design.netlify.com

@DiamondYuan DiamondYuan requested a review from afc163 Apr 10, 2019

@DiamondYuan DiamondYuan requested a review from afc163 Apr 10, 2019

@codecov

This comment has been minimized.

Copy link

commented Apr 11, 2019

Codecov Report

Merging #15996 into feature will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           feature   #15996      +/-   ##
===========================================
+ Coverage     95.1%    95.1%   +<.01%     
===========================================
  Files          251      251              
  Lines         6763     6764       +1     
  Branches      1935     1972      +37     
===========================================
+ Hits          6432     6433       +1     
  Misses         330      330              
  Partials         1        1
Impacted Files Coverage 螖
components/dropdown/dropdown-button.tsx 100% <100%> (酶) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 98fc8a1...f676cfa. Read the comment docs.

@DiamondYuan DiamondYuan requested a review from zombieJ Apr 11, 2019

@afc163

This comment has been minimized.

Copy link
Member

commented Apr 12, 2019

oops

@DiamondYuan

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 12, 2019

oops

蹇樿閲嶆柊 npm install 浜 馃槼

@afc163

This comment has been minimized.

Copy link
Member

commented Apr 12, 2019

rebase 澶辫触浜

@afc163
Copy link
Member

left a comment

mix other commits

@DiamondYuan

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 12, 2019

鍦ㄥ浗澶栧害鍋囷紝鍙兘鍙嶅簲鎱竴鐐广

@DiamondYuan DiamondYuan force-pushed the dropdown-right-cion branch from 25bbc3e to e99aada Apr 12, 2019

@DiamondYuan DiamondYuan requested a review from afc163 Apr 12, 2019

@DiamondYuan

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 12, 2019

搴旇馃憣

@DiamondYuan

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 12, 2019

CI 璺簡 浼间箮鏄 time picker 鏇存柊浜

@afc163

This comment has been minimized.

Copy link
Member

commented Apr 13, 2019

绛 master 鏇存柊鍒 feature

@afc163

This comment has been minimized.

Copy link
Member

commented Apr 14, 2019

浣犲彲浠 rebase feature 浜

@DiamondYuan DiamondYuan force-pushed the dropdown-right-cion branch from f96637a to 17b800f Apr 17, 2019

@DiamondYuan

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 17, 2019

image

鏈湴娴嬭瘯涓鐩磋窇涓嶈繃銆

npm install 浜嗐俽ebase feature 浜嗐

@afc163

This comment has been minimized.

Copy link
Member

commented Apr 17, 2019

瑕佹洿鏂版湰鍦 node_modules銆

@DiamondYuan

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 17, 2019

@afc163 ci 鍙堟寕浜嗕箞銆

image

@zombieJ

This comment has been minimized.

Copy link
Member

commented Apr 17, 2019

鍡紝 渚濊禆鐨 babel-plugin-add-module-exports 鎸備簡锛岀幇鍦ㄥソ浜嗐傛垜閲嶈窇涓涓

@DiamondYuan DiamondYuan requested review from afc163 and zombieJ Apr 18, 2019

@buildsize

This comment has been minimized.

Copy link

commented Apr 19, 2019

File name Previous Size New Size Change
package-lock.json 817.01聽KB 819.72聽KB 2.71聽KB (0%)

@DiamondYuan DiamondYuan requested review from zombieJ and afc163 Apr 19, 2019

@afc163

afc163 approved these changes Apr 19, 2019

@afc163 afc163 merged commit d65d68f into feature Apr 19, 2019

28 of 30 checks passed

Header rules No header rules processed
Details
Pages changed 212 new files uploaded
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
License Compliance All checks passed.
Details
Mixed content No mixed content detected
Details
Redirect rules 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize Significant change of package-lock.json up by 2.71聽KB (0.33%)
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codebeat Target branch is not tracked
Details
codecov/patch 100% of diff hit (target 95.1%)
Details
codecov/project 95.1% (+<.01%) compared to 98fc8a1
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@delete-merged-branch delete-merged-branch bot deleted the dropdown-right-cion branch Apr 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.