Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use Tabs overflow hidden instead of display none #16013

Merged
merged 2 commits into from Apr 11, 2019

Conversation

Projects
None yet
1 participant
@zombieJ
Copy link
Member

commented Apr 11, 2019

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

馃懟 What's the background?

fix #15352

馃挕 Solution

Display none makes sub Tabs can not get correct dom size. Use overflow hidden instead.

馃摑 Changelog

Fix nest Tabs ink bar style issue.

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

zombieJ added some commits Apr 10, 2019

@pr-triage pr-triage bot added the PR: unreviewed label Apr 11, 2019

@zombieJ zombieJ requested review from afc163 and ztplz Apr 11, 2019

@netlify

This comment has been minimized.

Copy link

commented Apr 11, 2019

Deploy preview for ant-design ready!

Built with commit 9f3e82f

https://deploy-preview-16013--ant-design.netlify.com

An enterprise-class UI design language and React-based implementation with a set of high-quality React components, one of best React UI library for enterprises
@codecov

This comment has been minimized.

Copy link

commented Apr 11, 2019

Codecov Report

Merging #16013 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16013      +/-   ##
==========================================
- Coverage   95.17%   95.13%   -0.05%     
==========================================
  Files         251      251              
  Lines        6721     6723       +2     
  Branches     1944     1957      +13     
==========================================
- Hits         6397     6396       -1     
- Misses        323      326       +3     
  Partials        1        1
Impacted Files Coverage 螖
components/_util/wave.tsx 85.57% <0%> (-2.89%) 猬囷笍
components/table/Table.tsx 92.97% <0%> (+0.02%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update df3e1b2...9f3e82f. Read the comment docs.

@zombieJ zombieJ merged commit 049fc17 into master Apr 11, 2019

29 of 31 checks passed

Header rules No header rules processed
Details
Pages changed 12 new files uploaded
Details
CodeFactor No issues found.
Details
DEP All dependencies are resolved
LGTM analysis: JavaScript No code changes detected
Details
License Compliance All checks passed.
Details
Mixed content No mixed content detected
Details
Redirect rules 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize No prior size to compare - 803.19聽KB
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codebeat no reportable quality changes
Details
codecov/patch Coverage not affected when comparing df3e1b2...9f3e82f
Details
codecov/project 95.13% (-0.05%) compared to df3e1b2
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@pr-triage pr-triage bot added PR: merged and removed PR: unreviewed labels Apr 11, 2019

@delete-merged-branch delete-merged-branch bot deleted the tab-hidden branch Apr 11, 2019

DiamondYuan added a commit that referenced this pull request Apr 12, 2019

fix: use Tabs overflow hidden instead of display none (#16013)
* fix nest table style

* use overflow hidden instead of display none

@weekly-digest weekly-digest bot referenced this pull request Apr 14, 2019

Closed

Weekly Digest (7 April, 2019 - 14 April, 2019) #16069

1 of 9 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.