Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use Tabs overflow hidden instead of display none #16013

Merged
merged 2 commits into from Apr 11, 2019
Merged

fix: use Tabs overflow hidden instead of display none #16013

merged 2 commits into from Apr 11, 2019

Conversation

@zombieJ
Copy link
Member

@zombieJ zombieJ commented Apr 11, 2019

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

馃懟 What's the background?

fix #15352

馃挕 Solution

Display none makes sub Tabs can not get correct dom size. Use overflow hidden instead.

馃摑 Changelog

Fix nest Tabs ink bar style issue.

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed
@zombieJ zombieJ requested review from afc163 and ztplz Apr 11, 2019
@netlify
Copy link

@netlify netlify bot commented Apr 11, 2019

Deploy preview for ant-design ready!

Built with commit 9f3e82f

https://deploy-preview-16013--ant-design.netlify.com

An enterprise-class UI design language and React-based implementation with a set of high-quality React components, one of best React UI library for enterprises

@codecov
Copy link

@codecov codecov bot commented Apr 11, 2019

Codecov Report

Merging #16013 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16013      +/-   ##
==========================================
- Coverage   95.17%   95.13%   -0.05%     
==========================================
  Files         251      251              
  Lines        6721     6723       +2     
  Branches     1944     1957      +13     
==========================================
- Hits         6397     6396       -1     
- Misses        323      326       +3     
  Partials        1        1
Impacted Files Coverage 螖
components/_util/wave.tsx 85.57% <0%> (-2.89%) 猬囷笍
components/table/Table.tsx 92.97% <0%> (+0.02%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update df3e1b2...9f3e82f. Read the comment docs.

@zombieJ zombieJ merged commit 049fc17 into master Apr 11, 2019
31 checks passed
@delete-merged-branch delete-merged-branch bot deleted the tab-hidden branch Apr 11, 2019
DiamondYuan added a commit that referenced this issue Apr 12, 2019
* fix nest table style

* use overflow hidden instead of display none
@yoyo837 yoyo837 mentioned this pull request Nov 20, 2019
1 task
@YJKZHUZHU
Copy link

@YJKZHUZHU YJKZHUZHU commented Nov 20, 2019

antd宸茬粡鏄渶鏂扮増鏈殑浜嗭紝浣嗚繕鏄嚭鐜颁簡杩欑鎯呭喌

@yoyo837
Copy link
Contributor

@yoyo837 yoyo837 commented Nov 20, 2019

@YJKZHUZHU https://new-issue.ant.design 鎻愪緵鏈夌敤淇℃伅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants