Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Empty in IE not fully render #16016

Merged
merged 3 commits into from Apr 11, 2019

Conversation

Projects
None yet
1 participant
@zombieJ
Copy link
Member

commented Apr 11, 2019

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

馃懟 What's the background?

fix #15314

馃挕 Solution

Add viewBox prop.

馃摑 Changelog

Fix Empty in IE not fully render

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

zombieJ added some commits Apr 11, 2019

@pr-triage pr-triage bot added the PR: unreviewed label Apr 11, 2019

@netlify

This comment has been minimized.

Copy link

commented Apr 11, 2019

Deploy preview for ant-design ready!

Built with commit c1dce45

https://deploy-preview-16016--ant-design.netlify.com

@codecov

This comment has been minimized.

Copy link

commented Apr 11, 2019

Codecov Report

Merging #16016 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #16016   +/-   ##
=======================================
  Coverage   95.13%   95.13%           
=======================================
  Files         251      251           
  Lines        6721     6721           
  Branches     1958     1922   -36     
=======================================
  Hits         6394     6394           
  Misses        326      326           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 41316e6...c1dce45. Read the comment docs.

@zombieJ zombieJ merged commit 38f701c into master Apr 11, 2019

28 of 30 checks passed

Header rules No header rules processed
Details
Pages changed 15 new files uploaded
Details
CodeFactor No issues found.
Details
LGTM analysis: JavaScript No code changes detected
Details
License Compliance All checks passed.
Details
Mixed content No mixed content detected
Details
Redirect rules 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize No change
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codebeat no reportable quality changes
Details
codecov/patch Coverage not affected when comparing 41316e6...c1dce45
Details
codecov/project 95.13% remains the same compared to 41316e6
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@delete-merged-branch delete-merged-branch bot deleted the ie11-empty branch Apr 11, 2019

@pr-triage pr-triage bot added PR: merged and removed PR: unreviewed labels Apr 11, 2019

DiamondYuan added a commit that referenced this pull request Apr 12, 2019

fix: Empty in IE not fully render (#16016)
* fix viewBox

* update snapshot

@weekly-digest weekly-digest bot referenced this pull request Apr 14, 2019

Closed

Weekly Digest (7 April, 2019 - 14 April, 2019) #16069

1 of 9 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.