Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: loading circle button can handle pointer events. #16063

Merged
merged 3 commits into from Apr 14, 2019
Merged

fix: loading circle button can handle pointer events. #16063

merged 3 commits into from Apr 14, 2019

Conversation

@gxvv
Copy link
Contributor

@gxvv gxvv commented Apr 13, 2019

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

馃懟 What's the background?

Different others loading button, the circle button can handle pointer events. Because it's excluded by the css selector &&-loading:not(&-circle):not(&-circle-outline):not(&-icon-only)

馃挕 Solution

Setting pointer-events: none; style to all loading button, and setting position: relative; for the pseudo of loading button can position to its parent.

馃摑 Changelog

  • English Changelog: fix: loading circle button can handle pointer events.
  • Chinese Changelog (optional):

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/button/demo/loading.md

@netlify
Copy link

@netlify netlify bot commented Apr 13, 2019

Deploy preview for ant-design ready!

Built with commit 9d95429

https://deploy-preview-16063--ant-design.netlify.com

@codecov
Copy link

@codecov codecov bot commented Apr 13, 2019

Codecov Report

Merging #16063 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16063      +/-   ##
==========================================
+ Coverage   95.13%   95.17%   +0.04%     
==========================================
  Files         251      251              
  Lines        6721     6721              
  Branches     1958     1958              
==========================================
+ Hits         6394     6397       +3     
+ Misses        326      323       -3     
  Partials        1        1
Impacted Files Coverage 螖
components/_util/wave.tsx 88.46% <0%> (+2.88%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 32bc699...d10ca0c. Read the comment docs.

@codecov
Copy link

@codecov codecov bot commented Apr 13, 2019

Codecov Report

Merging #16063 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #16063   +/-   ##
=======================================
  Coverage   95.13%   95.13%           
=======================================
  Files         251      251           
  Lines        6721     6721           
  Branches     1944     1922   -22     
=======================================
  Hits         6394     6394           
  Misses        326      326           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update fc83789...9d95429. Read the comment docs.

@@ -32,7 +32,7 @@ class App extends React.Component {

render() {
return (
<span>
<div>
Copy link
Member

@afc163 afc163 Apr 13, 2019

Any reasons to change this?

Copy link
Contributor Author

@gxvv gxvv Apr 13, 2019

A span tag contains too much tags that is weird.

@afc163 afc163 merged commit a091c72 into ant-design:master Apr 14, 2019
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants