Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Make notification functions accept top, bottom and getContainer as arguments #16123

Merged
merged 1 commit into from Apr 23, 2019

Conversation

Projects
None yet
3 participants
@Nouzbe
Copy link
Contributor

commented Apr 16, 2019

馃 This is a ...

  • New feature

馃懟 What's the background?

The notifications can be configured in two ways:

  • on the fly, per notification
  • globally, using the configure function

Except for top, bottom and getContainer which can only be configured globally.

#16107

馃挕 Solution

Let top, bottom and getContainer be defined on the fly per notification, like the rest of the configuration.

馃摑 Changelog

  • English Changelog:

Notifications functions accept top, bottom and getContainer as arguments. These properties could previously only be defined globally using the configure function.

  • Chinese Changelog (optional):

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/notification/index.en-US.md
View rendered components/notification/index.zh-CN.md

@pr-triage pr-triage bot added the PR: unreviewed label Apr 16, 2019

@netlify

This comment has been minimized.

Copy link

commented Apr 16, 2019

Deploy preview for ant-design ready!

Built with commit 163a21f

https://deploy-preview-16123--ant-design.netlify.com

@codecov

This comment has been minimized.

Copy link

commented Apr 16, 2019

Codecov Report

Merging #16123 into feature will decrease coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           feature   #16123      +/-   ##
===========================================
- Coverage    95.27%   95.23%   -0.05%     
===========================================
  Files          252      252              
  Lines         6773     6777       +4     
  Branches      1959     1974      +15     
===========================================
+ Hits          6453     6454       +1     
- Misses         319      322       +3     
  Partials         1        1
Impacted Files Coverage 螖
components/notification/index.tsx 96.15% <100%> (+0.2%) 猬嗭笍
components/_util/wave.tsx 85.57% <0%> (-2.89%) 猬囷笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 252e1dd...163a21f. Read the comment docs.

@ztplz

This comment has been minimized.

Copy link
Collaborator

commented Apr 16, 2019

Thanks. LGTM.

@Nouzbe Nouzbe changed the title Make notification functions accept top, bottom and getContainer as arguments feat: Make notification functions accept top, bottom and getContainer as arguments Apr 16, 2019

@afc163

This comment has been minimized.

Copy link
Member

commented Apr 19, 2019

Could you add some test cases?

@buildsize

This comment has been minimized.

Copy link

commented Apr 21, 2019

File name Previous Size New Size Change
package-lock.json 816.42聽KB 820.16聽KB 3.73聽KB (0%)
@Nouzbe

This comment has been minimized.

Copy link
Contributor Author

commented Apr 21, 2019

I can rebase and squash if it makes the review easier.

@afc163

This comment has been minimized.

Copy link
Member

commented Apr 22, 2019

You should pull and rebase feature branch to fix ci.

@Nouzbe Nouzbe force-pushed the Nouzbe:feature branch from 25267df to 163a21f Apr 22, 2019

@afc163

afc163 approved these changes Apr 23, 2019

@afc163 afc163 merged commit 7409150 into ant-design:feature Apr 23, 2019

27 of 29 checks passed

Header rules No header rules processed
Details
Pages changed 214 new files uploaded
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
Mixed content No mixed content detected
Details
Redirect rules 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize No change
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codebeat Target branch is not tracked
Details
codecov/patch 100% of diff hit (target 95.27%)
Details
codecov/project Absolute coverage decreased by -0.04% but relative coverage increased by +4.72% compared to 252e1dd
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.