Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix card mode Tabs border style when used with tabPosition="bottom" #16130

Merged
merged 2 commits into from Apr 23, 2019

Conversation

Projects
None yet
2 participants
@rinick
Copy link
Contributor

commented Apr 16, 2019

馃 This is a ...

  • Bug fix

馃懟 What's the background?

resolves #16012 : Bottom Card Tabs missing tab line

馃挕 Solution

& &-card-bar&-bottom-bar &-tab {
    height: auto;
}

馃摑 Changelog

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@pr-triage pr-triage bot added the PR: unreviewed label Apr 16, 2019

@netlify

This comment has been minimized.

Copy link

commented Apr 16, 2019

Deploy preview for ant-design ready!

Built with commit 23ed0cb

https://deploy-preview-16130--ant-design.netlify.com

@codecov

This comment has been minimized.

Copy link

commented Apr 22, 2019

Codecov Report

Merging #16130 into master will decrease coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16130      +/-   ##
==========================================
- Coverage   95.26%   95.14%   -0.13%     
==========================================
  Files         252      251       -1     
  Lines        6741     6735       -6     
  Branches     1950     1930      -20     
==========================================
- Hits         6422     6408      -14     
- Misses        318      326       +8     
  Partials        1        1
Impacted Files Coverage 螖
components/affix/utils.ts 79.31% <0%> (-20.69%) 猬囷笍
components/affix/index.tsx 92.2% <0%> (-2.92%) 猬囷笍
components/table/Table.tsx 92.94% <0%> (-0.02%) 猬囷笍
components/form/Form.tsx 88.88% <0%> (酶) 猬嗭笍
components/modal/Modal.tsx 100% <0%> (酶) 猬嗭笍
components/date-picker/InputIcon.tsx
components/date-picker/RangePicker.tsx 94.47% <0%> (+0.13%) 猬嗭笍
components/date-picker/WeekPicker.tsx 93.75% <0%> (+0.32%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 9fd27e0...23ed0cb. Read the comment docs.

@afc163 afc163 changed the title fix card mode Tabs border style when used with tabPosition="bottom" fix: fix card mode Tabs border style when used with tabPosition="bottom" Apr 23, 2019

@afc163 afc163 merged commit 9c11352 into ant-design:master Apr 23, 2019

27 of 29 checks passed

Header rules No header rules processed
Details
Pages changed 215 new files uploaded
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
CodeFactor No issues found.
Details
DEP All dependencies are resolved
LGTM analysis: JavaScript No code changes detected
Details
Mixed content No mixed content detected
Details
Redirect rules 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize No change
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codebeat 5 issues resolved and 1 introduced
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@pr-triage pr-triage bot added PR: merged and removed PR: unreviewed labels Apr 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.