Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Affix dynamic change target should work #16146

Merged
merged 2 commits into from Apr 17, 2019

Conversation

Projects
None yet
1 participant
@zombieJ
Copy link
Member

commented Apr 17, 2019

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

馃懟 What's the background?

fix #16140

馃挕 Solution

Always check target function

馃摑 Changelog

Fix Affix dynamic change target not work

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@pr-triage pr-triage bot added the PR: unreviewed label Apr 17, 2019

@codecov

This comment has been minimized.

Copy link

commented Apr 17, 2019

Codecov Report

Merging #16146 into master will increase coverage by 0.16%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16146      +/-   ##
==========================================
+ Coverage   95.14%   95.31%   +0.16%     
==========================================
  Files         251      251              
  Lines        6736     6743       +7     
  Branches     1965     1932      -33     
==========================================
+ Hits         6409     6427      +18     
+ Misses        326      315      -11     
  Partials        1        1
Impacted Files Coverage 螖
components/affix/index.tsx 95.12% <100%> (+2.91%) 猬嗭笍
components/affix/utils.ts 100% <100%> (+20.68%) 猬嗭笍
components/_util/wave.tsx 88.46% <0%> (+2.88%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 3a11402...d599917. Read the comment docs.

@netlify

This comment has been minimized.

Copy link

commented Apr 17, 2019

Deploy preview for ant-design ready!

Built with commit d599917

https://deploy-preview-16146--ant-design.netlify.com

@zombieJ zombieJ merged commit 9dbca66 into master Apr 17, 2019

28 of 31 checks passed

codebeat 0 issues resolved and 2 introduced
Details
Header rules No header rules processed
Details
Pages changed 211 new files uploaded
Details
CodeFactor 1 issue fixed. 1 issue found.
Details
DEP All dependencies are resolved
LGTM analysis: JavaScript No new or fixed alerts
Details
License Compliance All checks passed.
Details
Mixed content No mixed content detected
Details
Redirect rules 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize No change
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 95.14%)
Details
codecov/project 95.31% (+0.16%) compared to 3a11402
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@pr-triage pr-triage bot removed the PR: unreviewed label Apr 17, 2019

@delete-merged-branch delete-merged-branch bot deleted the fix-affix-target branch Apr 17, 2019

@pr-triage pr-triage bot added the PR: merged label Apr 17, 2019

afc163 added a commit that referenced this pull request Apr 18, 2019

Merge branch 'master' of github.com:ant-design/ant-design
* 'master' of github.com:ant-design/ant-design:
  docs: Fix selector in demo 'Playground'. (#16145)
  fix: Affix dynamic change target should work (#16146)
  chore: add pre-publish commit check (#16134)
  udpate warning (#16138)
  fix: form typescript definition (#16126)
  docs: Add FAQ of Affix window scroll (#16125)
  update demo (#16127)
  Update colors.en-US.md
  use 8px for radio circle (#16119)

BenjaVR added a commit to BenjaVR/ant-design that referenced this pull request Apr 21, 2019

BenjaVR added a commit to BenjaVR/ant-design that referenced this pull request Apr 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.