Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

add text selection in less vars so we can overwrite it independent #16155

Merged
merged 1 commit into from Apr 18, 2019

Conversation

Projects
None yet
2 participants
@moonrailgun
Copy link
Contributor

commented Apr 18, 2019

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

馃懟 What's the background?

Use less-loader to overwrite primary-color, but i dont like modify background style in ::selection

馃挕 Solution

add a independent less var to override. but its not affect default style

馃摑 Changelog

  • English Changelog:
    add less var text-selection-bg
  • Chinese Changelog (optional):
    澧炲姞less鍙橀噺text-selection-bg

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@pr-triage pr-triage bot added the PR: unreviewed label Apr 18, 2019

@codecov

This comment has been minimized.

Copy link

commented Apr 18, 2019

Codecov Report

Merging #16155 into master will decrease coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16155      +/-   ##
==========================================
- Coverage   95.26%   95.14%   -0.13%     
==========================================
  Files         251      251              
  Lines        6743     6736       -7     
  Branches     1932     1930       -2     
==========================================
- Hits         6424     6409      -15     
- Misses        318      326       +8     
  Partials        1        1
Impacted Files Coverage 螖
components/affix/utils.ts 79.31% <0%> (-20.69%) 猬囷笍
components/affix/index.tsx 92.2% <0%> (-2.92%) 猬囷笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 6e2c2ba...25599bc. Read the comment docs.

1 similar comment
@codecov

This comment has been minimized.

Copy link

commented Apr 18, 2019

Codecov Report

Merging #16155 into master will decrease coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16155      +/-   ##
==========================================
- Coverage   95.26%   95.14%   -0.13%     
==========================================
  Files         251      251              
  Lines        6743     6736       -7     
  Branches     1932     1930       -2     
==========================================
- Hits         6424     6409      -15     
- Misses        318      326       +8     
  Partials        1        1
Impacted Files Coverage 螖
components/affix/utils.ts 79.31% <0%> (-20.69%) 猬囷笍
components/affix/index.tsx 92.2% <0%> (-2.92%) 猬囷笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 6e2c2ba...25599bc. Read the comment docs.

@netlify

This comment has been minimized.

Copy link

commented Apr 18, 2019

Deploy preview for ant-design ready!

Built with commit 25599bc

https://deploy-preview-16155--ant-design.netlify.com

@afc163 afc163 merged commit 6a754eb into ant-design:master Apr 18, 2019

25 of 30 checks passed

codecov/project 95.14% (-0.13%) compared to 6e2c2ba
Details
Semantic Pull Request add a semantic commit or PR title
Details
codebeat 0 issues resolved and 2 introduced
Details
Header rules No header rules processed
Details
Pages changed 212 new files uploaded
Details
CodeFactor No issues found.
Details
DEP All dependencies are resolved
LGTM analysis: JavaScript No code changes detected
Details
Mixed content No mixed content detected
Details
Redirect rules 18 redirect rules processed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize No significant change
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 6e2c2ba...25599bc
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No new issues
Details

@pr-triage pr-triage bot added PR: merged and removed PR: unreviewed labels Apr 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.