Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typescript definition update #16202

Merged
merged 3 commits into from Apr 20, 2019

Conversation

Projects
None yet
2 participants
@zombieJ
Copy link
Member

commented Apr 20, 2019

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

馃懟 What's the background?

CI failed

馃挕 Solution

Icon definition updated.

@pr-triage pr-triage bot added the PR: unreviewed label Apr 20, 2019

@netlify

This comment has been minimized.

Copy link

commented Apr 20, 2019

Deploy preview for ant-design ready!

Built with commit a3a99d0

https://deploy-preview-16202--ant-design.netlify.com

@netlify

This comment has been minimized.

Copy link

commented Apr 20, 2019

Deploy preview for ant-design ready!

Built with commit 7a8e26c

https://deploy-preview-16202--ant-design.netlify.com

@netlify

This comment has been minimized.

Copy link

commented Apr 20, 2019

Deploy preview for ant-design ready!

Built with commit be0cf96

https://deploy-preview-16202--ant-design.netlify.com

@@ -33,7 +33,7 @@ export interface CustomIconComponentProps {
style?: React.CSSProperties;
spin?: boolean;
rotate?: number;
['aria-hidden']?: string;
['aria-hidden']?: boolean | 'true' | 'false';

This comment has been minimized.

Copy link
@afc163

afc163 Apr 20, 2019

Member

React.AriaAttributes['aria-hidden'] 杩欎釜涓鍔虫案閫搞

ant-design-icons 閲屼篃瑕佹敼鎺夈

@codecov

This comment has been minimized.

Copy link

commented Apr 20, 2019

Codecov Report

鉂楋笍 No coverage uploaded for pull request base (master@35da7ce). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #16202   +/-   ##
=========================================
  Coverage          ?   95.31%           
=========================================
  Files             ?      251           
  Lines             ?     6741           
  Branches          ?     1967           
=========================================
  Hits              ?     6425           
  Misses            ?      315           
  Partials          ?        1
Impacted Files Coverage 螖
components/icon/index.tsx 88% <酶> (酶)
components/icon/utils.ts 93.54% <酶> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 35da7ce...be0cf96. Read the comment docs.

@zombieJ zombieJ merged commit 5987792 into master Apr 20, 2019

27 of 30 checks passed

codebeat 0 issues resolved and 2 introduced
Details
Header rules No header rules processed
Details
Pages changed 211 new files uploaded
Details
CodeFactor No issues found.
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
License Compliance All checks passed.
Details
Mixed content No mixed content detected
Details
Redirect rules 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize No change
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected.
Details
codecov/project No report found to compare against
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@pr-triage pr-triage bot removed the PR: unreviewed label Apr 20, 2019

@delete-merged-branch delete-merged-branch bot deleted the fix-ts branch Apr 20, 2019

@pr-triage pr-triage bot added the PR: merged label Apr 20, 2019

BenjaVR added a commit to BenjaVR/ant-design that referenced this pull request Apr 21, 2019

fix: typescript definition update (ant-design#16202)
* fix lint

* update snapshot

* update define

BenjaVR added a commit to BenjaVR/ant-design that referenced this pull request Apr 22, 2019

fix: typescript definition update (ant-design#16202)
* fix lint

* update snapshot

* update define
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.