Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typescript definition update #16202

Merged
merged 3 commits into from Apr 20, 2019
Merged

fix: typescript definition update #16202

merged 3 commits into from Apr 20, 2019

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Apr 20, 2019

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

馃懟 What's the background?

CI failed

馃挕 Solution

Icon definition updated.

@netlify
Copy link

netlify bot commented Apr 20, 2019

Deploy preview for ant-design ready!

Built with commit a3a99d0

https://deploy-preview-16202--ant-design.netlify.com

@netlify
Copy link

netlify bot commented Apr 20, 2019

Deploy preview for ant-design ready!

Built with commit 7a8e26c

https://deploy-preview-16202--ant-design.netlify.com

@netlify
Copy link

netlify bot commented Apr 20, 2019

Deploy preview for ant-design ready!

Built with commit be0cf96

https://deploy-preview-16202--ant-design.netlify.com

@@ -33,7 +33,7 @@ export interface CustomIconComponentProps {
style?: React.CSSProperties;
spin?: boolean;
rotate?: number;
['aria-hidden']?: string;
['aria-hidden']?: boolean | 'true' | 'false';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

React.AriaAttributes['aria-hidden'] 杩欎釜涓鍔虫案閫搞

ant-design-icons 閲屼篃瑕佹敼鎺夈

@codecov
Copy link

codecov bot commented Apr 20, 2019

Codecov Report

鉂 No coverage uploaded for pull request base (master@35da7ce). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #16202   +/-   ##
=========================================
  Coverage          ?   95.31%           
=========================================
  Files             ?      251           
  Lines             ?     6741           
  Branches          ?     1967           
=========================================
  Hits              ?     6425           
  Misses            ?      315           
  Partials          ?        1
Impacted Files Coverage 螖
components/icon/index.tsx 88% <酶> (酶)
components/icon/utils.ts 93.54% <酶> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 35da7ce...be0cf96. Read the comment docs.

@zombieJ zombieJ merged commit 5987792 into master Apr 20, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix-ts branch April 20, 2019 15:38
@pr-triage pr-triage bot added the PR: merged label Apr 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants