Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ajudst typescript def of `allowSyntheticDefaultImports: false` user #16224

Merged
merged 1 commit into from Apr 22, 2019

Conversation

Projects
None yet
1 participant
@zombieJ
Copy link
Member

commented Apr 22, 2019

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

馃懟 What's the background?

close #16210

馃挕 Solution

import * as hoistNonReactStatics from 'hoist-non-react-statics';

馃摑 Changelog

Fix typescript hoist-non-react-statics' has no default export warning with allowSyntheticDefaultImports: false user.

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@pr-triage pr-triage bot added the PR: unreviewed label Apr 22, 2019

@netlify

This comment has been minimized.

Copy link

commented Apr 22, 2019

Deploy preview for ant-design ready!

Built with commit 203570e

https://deploy-preview-16224--ant-design.netlify.com

@codecov

This comment has been minimized.

Copy link

commented Apr 22, 2019

Codecov Report

Merging #16224 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16224      +/-   ##
==========================================
+ Coverage   95.26%   95.31%   +0.04%     
==========================================
  Files         252      252              
  Lines        6741     6741              
  Branches     1962     1962              
==========================================
+ Hits         6422     6425       +3     
+ Misses        318      315       -3     
  Partials        1        1
Impacted Files Coverage 螖
components/_util/wave.tsx 88.46% <0%> (+2.88%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 686c1fc...203570e. Read the comment docs.

@zombieJ zombieJ merged commit a530be1 into master Apr 22, 2019

29 of 31 checks passed

Header rules No header rules processed
Details
Pages changed 211 new files uploaded
Details
CodeFactor No issues found.
Details
DEP All dependencies are resolved
LGTM analysis: JavaScript No new or fixed alerts
Details
License Compliance All checks passed.
Details
Mixed content No mixed content detected
Details
Redirect rules 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize No prior size to compare - 819.83聽KB
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codebeat 5 issues resolved and 1 introduced
Details
codecov/patch Coverage not affected when comparing 686c1fc...203570e
Details
codecov/project 95.31% (+0.04%) compared to 686c1fc
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@pr-triage pr-triage bot added PR: merged and removed PR: unreviewed labels Apr 22, 2019

@delete-merged-branch delete-merged-branch bot deleted the ts-hoist branch Apr 22, 2019

@zombieJ zombieJ referenced this pull request Apr 22, 2019

Merged

docs: 3.16.5 changelog update #16233

1 of 9 tasks complete

jljsj33 added a commit that referenced this pull request Apr 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.