Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Drawer after visible change #16228

Merged
merged 3 commits into from Apr 23, 2019
Merged

feat: Drawer after visible change #16228

merged 3 commits into from Apr 23, 2019

Conversation

@jljsj33
Copy link
Member

@jljsj33 jljsj33 commented Apr 22, 2019

#16184


View rendered components/drawer/index.en-US.md
View rendered components/drawer/index.zh-CN.md

@jljsj33 jljsj33 requested a review from afc163 Apr 22, 2019
@buildsize
Copy link

@buildsize buildsize bot commented Apr 22, 2019

File name Previous Size New Size Change
package-lock.json 821.95 KB 820.32 KB -1.63 KB (0%)

@netlify
Copy link

@netlify netlify bot commented Apr 22, 2019

Deploy preview for ant-design ready!

Built with commit a1b5254

https://deploy-preview-16228--ant-design.netlify.com

@codecov
Copy link

@codecov codecov bot commented Apr 22, 2019

Codecov Report

Merging #16228 into feature will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           feature   #16228      +/-   ##
===========================================
- Coverage    95.27%   95.23%   -0.05%     
===========================================
  Files          252      252              
  Lines         6773     6773              
  Branches      1959     1936      -23     
===========================================
- Hits          6453     6450       -3     
- Misses         319      322       +3     
  Partials         1        1
Impacted Files Coverage Δ
components/drawer/index.tsx 98.68% <ø> (ø) ⬆️
components/_util/wave.tsx 85.57% <0%> (-2.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 252e1dd...a1b5254. Read the comment docs.

@afc163
Copy link
Member

@afc163 afc163 commented Apr 22, 2019

多了一个无关的 commit。

@jljsj33
Copy link
Member Author

@jljsj33 jljsj33 commented Apr 22, 2019

这 commit 哪来的??

@jljsj33 jljsj33 force-pushed the drawer-afterVisibleChange branch from ab05325 to 9deb3c5 Apr 22, 2019
@afc163
Copy link
Member

@afc163 afc163 commented Apr 22, 2019

你把自己的 commit 搞没了,厉害。

@jljsj33 jljsj33 force-pushed the drawer-afterVisibleChange branch from 9deb3c5 to 86b8a1c Apr 22, 2019
@jljsj33
Copy link
Member Author

@jljsj33 jljsj33 commented Apr 22, 2019

哈哈哈,,误操作了,,又不是搞不回来。

components/drawer/index.tsx Outdated Show resolved Hide resolved
@afc163 afc163 changed the title Drawer after visible change feat: Drawer after visible change Apr 23, 2019
afc163
afc163 approved these changes Apr 23, 2019
@afc163 afc163 merged commit b0f0509 into feature Apr 23, 2019
30 of 31 checks passed
@delete-merged-branch delete-merged-branch bot deleted the drawer-afterVisibleChange branch Apr 23, 2019
@YingJian-hu
Copy link

@YingJian-hu YingJian-hu commented May 16, 2019

这个属性触发的函数为啥会调2次呢?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants