Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Select active item hover color is wrong #16238

Merged
merged 1 commit into from Apr 22, 2019
Merged

fix: Select active item hover color is wrong #16238

merged 1 commit into from Apr 22, 2019

Conversation

@yociduo
Copy link
Contributor

@yociduo yociduo commented Apr 22, 2019

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

馃懟 What's the background?

fix #16234

馃挕 Solution

Remove hover color for selected

馃摑 Changelog

Fix Select active & hover item display color priority.

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed
@netlify
Copy link

@netlify netlify bot commented Apr 22, 2019

Deploy preview for ant-design ready!

Built with commit 4f3bca7

https://deploy-preview-16238--ant-design.netlify.com

@codecov
Copy link

@codecov codecov bot commented Apr 22, 2019

Codecov Report

Merging #16238 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #16238   +/-   ##
=======================================
  Coverage   95.26%   95.26%           
=======================================
  Files         252      252           
  Lines        6741     6741           
  Branches     1950     1950           
=======================================
  Hits         6422     6422           
  Misses        318      318           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update aab2693...4f3bca7. Read the comment docs.

1 similar comment
@codecov
Copy link

@codecov codecov bot commented Apr 22, 2019

Codecov Report

Merging #16238 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #16238   +/-   ##
=======================================
  Coverage   95.26%   95.26%           
=======================================
  Files         252      252           
  Lines        6741     6741           
  Branches     1950     1950           
=======================================
  Hits         6422     6422           
  Misses        318      318           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update aab2693...4f3bca7. Read the comment docs.

@zombieJ
Copy link
Member

@zombieJ zombieJ commented Apr 22, 2019

@zombieJ zombieJ merged commit 9fd27e0 into ant-design:master Apr 22, 2019
30 checks passed
@yociduo yociduo deleted the select-active-hover branch Apr 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants