Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Select active item hover color is wrong #16238

Merged
merged 1 commit into from Apr 22, 2019

Conversation

Projects
None yet
2 participants
@yociduo
Copy link
Contributor

commented Apr 22, 2019

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

馃懟 What's the background?

fix #16234

馃挕 Solution

Remove hover color for selected

馃摑 Changelog

Fix Select active & hover item display color priority.

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@pr-triage pr-triage bot added the PR: unreviewed label Apr 22, 2019

@netlify

This comment has been minimized.

Copy link

commented Apr 22, 2019

Deploy preview for ant-design ready!

Built with commit 4f3bca7

https://deploy-preview-16238--ant-design.netlify.com

@codecov

This comment has been minimized.

Copy link

commented Apr 22, 2019

Codecov Report

Merging #16238 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #16238   +/-   ##
=======================================
  Coverage   95.26%   95.26%           
=======================================
  Files         252      252           
  Lines        6741     6741           
  Branches     1950     1950           
=======================================
  Hits         6422     6422           
  Misses        318      318           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update aab2693...4f3bca7. Read the comment docs.

1 similar comment
@codecov

This comment has been minimized.

Copy link

commented Apr 22, 2019

Codecov Report

Merging #16238 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #16238   +/-   ##
=======================================
  Coverage   95.26%   95.26%           
=======================================
  Files         252      252           
  Lines        6741     6741           
  Branches     1950     1950           
=======================================
  Hits         6422     6422           
  Misses        318      318           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update aab2693...4f3bca7. Read the comment docs.

@zombieJ

This comment has been minimized.

Copy link
Member

commented Apr 22, 2019

@zombieJ zombieJ merged commit 9fd27e0 into ant-design:master Apr 22, 2019

28 of 30 checks passed

Header rules No header rules processed
Details
Pages changed 213 new files uploaded
Details
CodeFactor No issues found.
Details
DEP All dependencies are resolved
LGTM analysis: JavaScript No code changes detected
Details
Mixed content No mixed content detected
Details
Redirect rules 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize No change
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codebeat 5 issues resolved and 1 introduced
Details
codecov/patch Coverage not affected when comparing aab2693...4f3bca7
Details
codecov/project 95.26% remains the same compared to aab2693
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@pr-triage pr-triage bot added PR: merged and removed PR: unreviewed labels Apr 22, 2019

@yociduo yociduo deleted the yociduo:select-active-hover branch Apr 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.