Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: List with actions style should be the right #16239

Merged
merged 3 commits into from Apr 24, 2019
Merged

fix: List with actions style should be the right #16239

merged 3 commits into from Apr 24, 2019

Conversation

@zombieJ
Copy link
Member

@zombieJ zombieJ commented Apr 22, 2019

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

馃懟 What's the background?

fix #16232

馃挕 Solution

Add float: right to the actions.

馃摑 Changelog

Fix List with actions style not be the right

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed
@zombieJ zombieJ requested a review from afc163 Apr 22, 2019
@zombieJ
Copy link
Member Author

@zombieJ zombieJ commented Apr 22, 2019

Not sure if its the correct answer. Please help to check @afc163

Loading

@netlify
Copy link

@netlify netlify bot commented Apr 22, 2019

Deploy preview for ant-design ready!

Built with commit 337c9f4

https://deploy-preview-16239--ant-design.netlify.com

Loading

@codecov
Copy link

@codecov codecov bot commented Apr 22, 2019

Codecov Report

Merging #16239 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16239      +/-   ##
==========================================
+ Coverage   95.26%   95.26%   +<.01%     
==========================================
  Files         252      253       +1     
  Lines        6741     6743       +2     
  Branches     1950     1927      -23     
==========================================
+ Hits         6422     6424       +2     
  Misses        318      318              
  Partials        1        1
Impacted Files Coverage 螖
components/list/Item.tsx 100% <100%> (酶) 猬嗭笍
components/_util/reactNode.ts 100% <100%> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 9fd27e0...337c9f4. Read the comment docs.

Loading

@afc163
Copy link
Member

@afc163 afc163 commented Apr 23, 2019

鍙互鐢ㄨ繖涓帓鏌ヤ竴涓 #15329

Loading

.@{list-prefix-cls}-item-action {
float: right;
}
}
Copy link
Member

@afc163 afc163 Apr 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

濂藉儚娌″繀瑕佷粠 &-item 閲岀Щ鍑烘潵锛

Loading

Copy link
Member Author

@zombieJ zombieJ Apr 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

鎸夊姛鑳藉垝鍒嗕负浜嗕互鍚庢壘鍜屽鐞嗚捣鏉ユ柟渚

Loading

@zombieJ zombieJ merged commit e541a24 into master Apr 24, 2019
31 checks passed
Loading
@delete-merged-branch delete-merged-branch bot deleted the list-without-flex branch Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants