Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: List with actions style should be the right #16239

Merged
merged 3 commits into from Apr 24, 2019

Conversation

Projects
None yet
2 participants
@zombieJ
Copy link
Member

commented Apr 22, 2019

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

馃懟 What's the background?

fix #16232

馃挕 Solution

Add float: right to the actions.

馃摑 Changelog

Fix List with actions style not be the right

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@zombieJ zombieJ requested a review from afc163 Apr 22, 2019

@pr-triage pr-triage bot added the PR: unreviewed label Apr 22, 2019

@zombieJ

This comment has been minimized.

Copy link
Member Author

commented Apr 22, 2019

Not sure if its the correct answer. Please help to check @afc163

@netlify

This comment has been minimized.

Copy link

commented Apr 22, 2019

Deploy preview for ant-design ready!

Built with commit 337c9f4

https://deploy-preview-16239--ant-design.netlify.com

@codecov

This comment has been minimized.

Copy link

commented Apr 22, 2019

Codecov Report

Merging #16239 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16239      +/-   ##
==========================================
+ Coverage   95.26%   95.26%   +<.01%     
==========================================
  Files         252      253       +1     
  Lines        6741     6743       +2     
  Branches     1950     1927      -23     
==========================================
+ Hits         6422     6424       +2     
  Misses        318      318              
  Partials        1        1
Impacted Files Coverage 螖
components/list/Item.tsx 100% <100%> (酶) 猬嗭笍
components/_util/reactNode.ts 100% <100%> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 9fd27e0...337c9f4. Read the comment docs.

@afc163

This comment has been minimized.

Copy link
Member

commented Apr 23, 2019

鍙互鐢ㄨ繖涓帓鏌ヤ竴涓 #15329

.@{list-prefix-cls}-item-action {
float: right;
}
}

This comment has been minimized.

Copy link
@afc163

afc163 Apr 23, 2019

Member

濂藉儚娌″繀瑕佷粠 &-item 閲岀Щ鍑烘潵锛

This comment has been minimized.

Copy link
@zombieJ

zombieJ Apr 24, 2019

Author Member

鎸夊姛鑳藉垝鍒嗕负浜嗕互鍚庢壘鍜屽鐞嗚捣鏉ユ柟渚

zombieJ added some commits Apr 24, 2019

@zombieJ zombieJ merged commit e541a24 into master Apr 24, 2019

29 of 31 checks passed

Header rules No header rules processed
Details
Pages changed 211 new files uploaded
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
CodeFactor No issues found.
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
License Compliance All checks passed.
Details
Mixed content No mixed content detected
Details
Redirect rules 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize No change
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codebeat 5 issues resolved and 1 introduced
Details
codecov/patch 100% of diff hit (target 95.26%)
Details
codecov/project 95.26% (+<.01%) compared to 9fd27e0
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No new issues
Details

@delete-merged-branch delete-merged-branch bot deleted the list-without-flex branch Apr 24, 2019

@pr-triage pr-triage bot added PR: merged and removed PR: unreviewed labels Apr 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.